From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF1AC433F5 for ; Thu, 29 Sep 2022 14:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234255AbiI2OMr convert rfc822-to-8bit (ORCPT ); Thu, 29 Sep 2022 10:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235606AbiI2OMk (ORCPT ); Thu, 29 Sep 2022 10:12:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85F361B85E4; Thu, 29 Sep 2022 07:12:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21E3A614C1; Thu, 29 Sep 2022 14:12:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66699C433D6; Thu, 29 Sep 2022 14:12:37 +0000 (UTC) Date: Thu, 29 Sep 2022 10:13:49 -0400 From: Steven Rostedt To: Ulf Hansson Cc: "dinggao.pan" , "bigeasy@linutronix.de" , "tglx@linutronix.de" , "ming.yu" , "yunqian.wang" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rt-users@vger.kernel.org" , "Luis Claudio R. Goncalves" Subject: Re: [PATCH RFC stable 4.14 1/1] mmc: core: fix hung task caused by race condition on context_info Message-ID: <20220929101349.25c835db@gandalf.local.home> In-Reply-To: <20220929100750.172e53d4@gandalf.local.home> References: <21f604139a9a4675b9ed49292839dcfb@horizon.ai> <20220929100750.172e53d4@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Sep 2022 10:07:50 -0400 Steven Rostedt wrote: > On Thu, 29 Sep 2022 14:41:26 +0200 > Ulf Hansson wrote: > > > On Mon, 5 Sept 2022 at 08:22, dinggao.pan wrote: > > > > > > Hi, > > > After applying rt patches to our 4.14 kernel and enabling preempt-rt, we met a hung task during boot caused by race condition on context_info stored in struct mmc_host. > > > From our investigation, context_info should not be changed by threads that have not claimed the host, hence the following fix. > > > > > > Any comments are much appreciated. > > > Dinggao Pan > > > > Hi Dinggao, > > > > Apologize for the delay. > > > > The 4.14 kernel is too old for me to be able to comment. In > > particular, the mmc block layer moved to blk-mq in v4.16, which means > > the path you are investigating doesn't exist any more, sorry. > > Luis (Cc'd) is still supporting the 4.14-rt kernel. It appears that I have an old email address for Luis, and it bounced. Updated with his redhat one. -- Steve > > > > > Kind regards > > Uffe > > > > > > > > From: "Dinggao Pan" > > > > > > 　　A race condition happens under following circumstances: > > > (mmc_thread1) | (mmc_thread2) > > > mmc_issue_rq(req1) | > > > > qcnt++ for req1 | > > > host handling req1 | > > > mmc_queue_thread(req=null) | > > > > enter queue thread | > > > again, fetches blk req | > > > (return null), sets | > > > is_waiting_last_req 1 | mmc_request_fn(req1) -> set is_new_req 1 > > > | and wake_up wait_queue > > > mmc_issue_rq(req2) | > mmc_thread2 tries to claim host > > > > **qcnt++ for req2** | > > > mmc_finalize_req(req2) | > > > > should wait for req1 | > > > done but req2 return | > > > MMC_BLK_NEW_REQ | > > > due to is_new_req | > > > already set to 1 | > > > | > > > | > > > req1 done | > > > > qcnt-- for req1 | > > > mmc_issue_rq(req3) | > > > > qcnt++ for req3 | > > > req2 is not handled but qcnt is already added(noted by **), > > > thus mmc_thread1 will never release host, causing mmc_threads > > > except thread1 to hung. Fix race by moving wake_up to the front of > > > context_info update. > > > > > > Reviewed By: Yunqian Wang > > > Signed-off-by: Dinggao Pan > > > Signed-off-by: Ming Yu > > > --- > > > drivers/mmc/core/queue.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > > > index 0a4e77a5b..58318c102 100644 > > > --- a/drivers/mmc/core/queue.c > > > +++ b/drivers/mmc/core/queue.c > > > @@ -107,6 +107,11 @@ static void mmc_request_fn(struct request_queue *q) > > > return; > > > } > > > > > > + if (mq->asleep) { > > > + wake_up_process(mq->thread); > > > + return; > > > + } > > > + > > > cntx = &mq->card->host->context_info; > > > > > > if (cntx->is_waiting_last_req) { > > > @@ -114,8 +119,6 @@ static void mmc_request_fn(struct request_queue *q) > > > wake_up_interruptible(&cntx->wait); > > > } > > > > > > - if (mq->asleep) > > > - wake_up_process(mq->thread); > > > } > > > > > > static struct scatterlist *mmc_alloc_sg(int sg_len, gfp_t gfp) > > > -- > > > 2.36.1 >