From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3905CC433FE for ; Thu, 29 Sep 2022 17:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234934AbiI2RXh (ORCPT ); Thu, 29 Sep 2022 13:23:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235150AbiI2RXS (ORCPT ); Thu, 29 Sep 2022 13:23:18 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B388F1F11CA for ; Thu, 29 Sep 2022 10:22:04 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id y136so2032102pfb.3 for ; Thu, 29 Sep 2022 10:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=mB8DS4FtbYahqmKbTsOUSTFLoTQRXcbJ3S67QhTIGmqSBDz/tWrFlwMcQ+cr23xX+b QjG8yy4p2rhzXPmzYoPpJETh+MOcZ4yLkpS+xe/4UC0kekmTGp2l0FOavxZbRoTOhb+3 XH0z/AGyy1pyfbaQ0b8WlaXjjULk5lXJ98RdhAuDRK1jZK174zRJLrai1dB3qYm7C9bi mfxenLf2PEEAJXuAgS23CChpXtK7E5L++pMmei3EFlv/p6bQLa1s2fnPxLJwYph9MUyh Id4k8Zu0gFKur4uSD2lyGzTjCb8tFTcmzTfGvpSNt2i8W6+NVwbl2mPn83HI9mJB9uQj Gugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=hbAk5l3LQ+YDW3+yRo/6NkC8/wKgVX1+YIfsprfK6P92NOZT59VDK6Zt88iO628rNi f3jeEEFfhL3NIvzRAb5+oBk1mXu74R5jvpvTYFhK1+FQtWn/NWkoRs4UmNwhACr+IML6 viaTf04mN94CMQnxXyjic4XRYwbtl5VopJ+ADNm54wSZMjWp1Fxxo+3fFFrraJAGyQLJ h28AnfKf6hLNGUSjb0g7YELMoLfCjveyuT9YDMT3bgv0P0LP5VP0+NHSZCXmK+IHK5AZ kmKU9aKH/0MxqPdPK0yAu/vrk9uSc9tILlbctS+izUtxw+bxexh+0O/7FQuw2EEuC15p m0rQ== X-Gm-Message-State: ACrzQf0LIVsJIsvZuFUUM/n4wIk60a1g8/C+sNzwbHI0UScaEFApXxE3 r64hCGCe5TG0As6IU/vEm/VvTg== X-Google-Smtp-Source: AMsMyM4AC3DhaeWsDiKxbTYHV9WoijHDEhKnl9Ddx2dx4JeYbpJ/IXYZuywwehHTWBeATWePCuxzFg== X-Received: by 2002:a05:6a00:1a47:b0:52e:6a8c:5430 with SMTP id h7-20020a056a001a4700b0052e6a8c5430mr4622875pfv.48.1664472123633; Thu, 29 Sep 2022 10:22:03 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id j13-20020a17090a694d00b00205da989de3sm36917pjm.17.2022.09.29.10.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 10:22:02 -0700 (PDT) Date: Thu, 29 Sep 2022 11:22:00 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, tanmay.shah@xilinx.com, michal.simek@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Message-ID: <20220929172200.GB3107608@p14s> References: <20220708013955.2340449-1-tanmay.shah@amd.com> <20220708013955.2340449-7-tanmay.shah@amd.com> <20220901202517.GB626605@p14s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Sep 26, 2022 at 03:02:22PM -0700, Tanmay Shah wrote: > > On 9/1/22 1:25 PM, Mathieu Poirier wrote: > > On Thu, Jul 07, 2022 at 06:39:55PM -0700, Tanmay Shah wrote: > [ ... ] > > > --- /dev/null > > > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > > > @@ -0,0 +1,1055 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > Hi Mathieu, > > I tried to fix SPDX-License-Identifier to GPL (same as MODULE_LICENSE > below), However checkpatch.pl reports this as following warning: > > "WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/..." > > I see that GPL-1.0 is under LICENSE/deprecated directory. > > > > +/* > > > + * ZynqMP R5 Remote Processor driver > > > + * > > > + */ > > > + > > > +#include > > [ ... ] > > > > +MODULE_DEVICE_TABLE(of, zynqmp_r5_remoteproc_match); > > > + > > > +static struct platform_driver zynqmp_r5_remoteproc_driver = { > > > + .probe = zynqmp_r5_remoteproc_probe, > > > + .driver = { > > > + .name = "zynqmp_r5_remoteproc", > > > + .of_match_table = zynqmp_r5_remoteproc_match, > > > + }, > > > +}; > > > +module_platform_driver(zynqmp_r5_remoteproc_driver); > > > + > > > +MODULE_DESCRIPTION("Xilinx R5F remote processor driver"); > > > +MODULE_AUTHOR("Xilinx Inc."); > > > +MODULE_LICENSE("GPL"); > > There is a discrepency between the GPL-2.0 in the SPDS identifier and the above. > > Also, changing to MODULE_LICENSE("GPL v2") gives following warning: > > WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure > the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > #1115: FILE: drivers/remoteproc/xlnx_r5_remoteproc.c:1034: > +MODULE_LICENSE("GPL v2"); > > So, It looks like SPDX-License-Identifier should be GPL-2.0-only and > MODULE_LICENSE should be change to "GPL". Commit bf7fbeeae6db is an interesting read - thanks for pointing it out. > > It this ok? Any other suggestions ? What you have looks good, in that regard there is no need to change anything from your patch. > > Thanks, > > Tanmay > > > > > More comments tomorrow or Tuesday. > > > > Thanks, > > Mathieu > > > > > -- > > > 2.25.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3062C433FE for ; Thu, 29 Sep 2022 17:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KblsWhAjUGfkMVM3vY2wnBzdkllne/Q6PFE1d+Kc++s=; b=zNI2fFhiUm4C/c 4K503gZOYE9BLfnv7qhj0cbsvmnFXLeswRNCqJKasf0G1018wy9Pi3/03QO5bZgcZ63Gnm9LM2nZv 4c91sKJ6HISNUoIbMYIOum3Nh/6pgxas1kySiqyJe+MmgwUXqUVldxXg3Rv5lVLjRcGByJuiPVIMS tR0UW2nDQFsgKOBbYM1Xto8YOjwe8Jg3GDSc0co/RFkpnDzvp1VESJ6fChXWFAjL/J8zF47eSITsT HT3vndM+FqSX+sbSbhrkcZ+z44Bl11axFzdKq6CVm9AShzYnZRLgnotkCMsjzNxiSpTkbHIvtAhZO BuHoxB7wyWNXEKo8AMbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odxFI-004ZIN-6k; Thu, 29 Sep 2022 17:22:48 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odxEj-004YyP-4S for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 17:22:16 +0000 Received: by mail-pf1-x42c.google.com with SMTP id v186so2017671pfv.11 for ; Thu, 29 Sep 2022 10:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=mB8DS4FtbYahqmKbTsOUSTFLoTQRXcbJ3S67QhTIGmqSBDz/tWrFlwMcQ+cr23xX+b QjG8yy4p2rhzXPmzYoPpJETh+MOcZ4yLkpS+xe/4UC0kekmTGp2l0FOavxZbRoTOhb+3 XH0z/AGyy1pyfbaQ0b8WlaXjjULk5lXJ98RdhAuDRK1jZK174zRJLrai1dB3qYm7C9bi mfxenLf2PEEAJXuAgS23CChpXtK7E5L++pMmei3EFlv/p6bQLa1s2fnPxLJwYph9MUyh Id4k8Zu0gFKur4uSD2lyGzTjCb8tFTcmzTfGvpSNt2i8W6+NVwbl2mPn83HI9mJB9uQj Gugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SIbDPYXTiEpHr31cowPm5hEWT0Dsj29GpYNVG6B6LlQ=; b=ZzG6gAo1iayR88Wxg4YZT9T6foEJ1ccCt3q94j0fZiYTebFebpA4wSLlgNtQyFYCZY 3mAj77XV/tPg+1y4ybTjfqI2HBHaBljD12a5GWWk5Z0L39l9Oi5b7iY9P/o5QF5vBO45 r1R7iYGf6oBRB3f53Ayrp2/hdcPuYKtVFqExo6gG8XY8Wbg7qxlGLJZM91OJL1vO70dE nVcsRNoNjMLYOeoGF5i5AaoeN0rO/xY7WiARSg/i6YmqDjGPcS4UZAJ9JVqI/Ay4RRDe 1OUwNfRAhgqukJuV3lE4V/Bgx4oRmwb+8KxC2KOyajaayzSQF45nIPtwiNhf44QweL46 H6/A== X-Gm-Message-State: ACrzQf1iV5FU7s3aww8T7C5qw9Hj6nuHDVsetW+xauZxNCmnCcIqGpiM H2qyj3iIKbCSHWu1g7bBd/O2yg== X-Google-Smtp-Source: AMsMyM4AC3DhaeWsDiKxbTYHV9WoijHDEhKnl9Ddx2dx4JeYbpJ/IXYZuywwehHTWBeATWePCuxzFg== X-Received: by 2002:a05:6a00:1a47:b0:52e:6a8c:5430 with SMTP id h7-20020a056a001a4700b0052e6a8c5430mr4622875pfv.48.1664472123633; Thu, 29 Sep 2022 10:22:03 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id j13-20020a17090a694d00b00205da989de3sm36917pjm.17.2022.09.29.10.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 10:22:02 -0700 (PDT) Date: Thu, 29 Sep 2022 11:22:00 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, tanmay.shah@xilinx.com, michal.simek@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Message-ID: <20220929172200.GB3107608@p14s> References: <20220708013955.2340449-1-tanmay.shah@amd.com> <20220708013955.2340449-7-tanmay.shah@amd.com> <20220901202517.GB626605@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_102213_251638_6B6AA91F X-CRM114-Status: GOOD ( 26.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 26, 2022 at 03:02:22PM -0700, Tanmay Shah wrote: > > On 9/1/22 1:25 PM, Mathieu Poirier wrote: > > On Thu, Jul 07, 2022 at 06:39:55PM -0700, Tanmay Shah wrote: > [ ... ] > > > --- /dev/null > > > +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > > > @@ -0,0 +1,1055 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > Hi Mathieu, > > I tried to fix SPDX-License-Identifier to GPL (same as MODULE_LICENSE > below), However checkpatch.pl reports this as following warning: > > "WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/..." > > I see that GPL-1.0 is under LICENSE/deprecated directory. > > > > +/* > > > + * ZynqMP R5 Remote Processor driver > > > + * > > > + */ > > > + > > > +#include > > [ ... ] > > > > +MODULE_DEVICE_TABLE(of, zynqmp_r5_remoteproc_match); > > > + > > > +static struct platform_driver zynqmp_r5_remoteproc_driver = { > > > + .probe = zynqmp_r5_remoteproc_probe, > > > + .driver = { > > > + .name = "zynqmp_r5_remoteproc", > > > + .of_match_table = zynqmp_r5_remoteproc_match, > > > + }, > > > +}; > > > +module_platform_driver(zynqmp_r5_remoteproc_driver); > > > + > > > +MODULE_DESCRIPTION("Xilinx R5F remote processor driver"); > > > +MODULE_AUTHOR("Xilinx Inc."); > > > +MODULE_LICENSE("GPL"); > > There is a discrepency between the GPL-2.0 in the SPDS identifier and the above. > > Also, changing to MODULE_LICENSE("GPL v2") gives following warning: > > WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure > the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > #1115: FILE: drivers/remoteproc/xlnx_r5_remoteproc.c:1034: > +MODULE_LICENSE("GPL v2"); > > So, It looks like SPDX-License-Identifier should be GPL-2.0-only and > MODULE_LICENSE should be change to "GPL". Commit bf7fbeeae6db is an interesting read - thanks for pointing it out. > > It this ok? Any other suggestions ? What you have looks good, in that regard there is no need to change anything from your patch. > > Thanks, > > Tanmay > > > > > More comments tomorrow or Tuesday. > > > > Thanks, > > Mathieu > > > > > -- > > > 2.25.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel