All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC PATCH] lvmlockd: purge the lock resources left in previous lockspace
Date: Fri, 30 Sep 2022 10:32:51 -0500	[thread overview]
Message-ID: <20220930153251.GA1502@redhat.com> (raw)
In-Reply-To: <ff6e311a-5e87-2fe8-7c11-46aa7aaa048e@suse.com>

On Fri, Sep 30, 2022 at 09:57:08PM +0800, Lidong Zhong wrote:
> ???? /* FIXME: purge any remaining orphan locks in each rejoined ls? */

You're fixing it, so we can drop the comment.

> +??? ??? ??? ??? file = fopen(ls_comms_path, "r");
> +??? ??? ??? ??? if (!file)
> +??? ??? ??? ??? ??? continue;
> +??? ??? ??? ??? if (fgets(line, LOCK_LINE_MAX, file)) {
> +??? ??? ??? ??? ??? rv = sscanf(line, "%d", &val);
> +??? ??? ??? ??? ??? if (rv == 1)
> +??? ??? ??? ??? ??? ??? return val;

Is this missing an fclose?

Please confirm that this works for your test case and I'll include it.

Thanks,
Dave

  reply	other threads:[~2022-09-30 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 13:57 [RFC PATCH] lvmlockd: purge the lock resources left in previous lockspace Lidong Zhong
2022-09-30 15:32 ` David Teigland [this message]
2022-10-05  5:34   ` Lidong Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220930153251.GA1502@redhat.com \
    --to=teigland@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.