All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org, m.szyprowski@samsung.com
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER),
	linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
	DRIVER),
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
	S3C, S5P AND EXYNOS ARM ARCHITECTURES),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp
Date: Mon,  3 Oct 2022 15:29:43 +0200	[thread overview]
Message-ID: <20221003132943.1383065-1-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com>

The driver is assuming the get_critical temperature exists as it is
inherited by the thermal of ops. But this one has been removed in
favor of the generic one.

Use the generic thermal_zone_get_crit_temp() function instead

Fixes: 13bea86623b ("thermal/of: Remove of_thermal_get_crit_temp(")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/samsung/exynos_tmu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 5a1ffe2f3134..37465af59262 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -264,9 +264,8 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 	unsigned int status;
 	int ret = 0, temp;
 
-	if (data->soc != SOC_ARCH_EXYNOS5433) /* FIXME */
-		ret = tzd->ops->get_crit_temp(tzd, &temp);
-	if (ret) {
+	ret = thermal_zone_get_crit_temp(tzd, &temp);
+	if (ret && data->soc != SOC_ARCH_EXYNOS5433) { /* FIXME */
 		dev_err(&pdev->dev,
 			"No CRITICAL trip point defined in device tree!\n");
 		goto out;
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org, m.szyprowski@samsung.com
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-pm@vger.kernel.org (open list:SAMSUNG THERMAL DRIVER),
	linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
	DRIVER),
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
	S3C, S5P AND EXYNOS ARM ARCHITECTURES),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp
Date: Mon,  3 Oct 2022 15:29:43 +0200	[thread overview]
Message-ID: <20221003132943.1383065-1-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <4e4d873b-4a40-334a-34e7-defb0fcc4e6b@samsung.com>

The driver is assuming the get_critical temperature exists as it is
inherited by the thermal of ops. But this one has been removed in
favor of the generic one.

Use the generic thermal_zone_get_crit_temp() function instead

Fixes: 13bea86623b ("thermal/of: Remove of_thermal_get_crit_temp(")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/samsung/exynos_tmu.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 5a1ffe2f3134..37465af59262 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -264,9 +264,8 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 	unsigned int status;
 	int ret = 0, temp;
 
-	if (data->soc != SOC_ARCH_EXYNOS5433) /* FIXME */
-		ret = tzd->ops->get_crit_temp(tzd, &temp);
-	if (ret) {
+	ret = thermal_zone_get_crit_temp(tzd, &temp);
+	if (ret && data->soc != SOC_ARCH_EXYNOS5433) { /* FIXME */
 		dev_err(&pdev->dev,
 			"No CRITICAL trip point defined in device tree!\n");
 		goto out;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-03 13:30 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221003092704eucas1p2875c1f996dfd60a58f06cf986e02e8eb@eucas1p2.samsung.com>
2022-10-03  9:25 ` [PATCH v8 00/29] Rework the trip points creation Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 01/29] thermal/core: Add a generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2023-03-12 12:14     ` [PATCH v8 01/29] " Ido Schimmel
2023-03-13 10:45       ` Daniel Lezcano
2023-03-13 12:12         ` Ido Schimmel
2022-10-03  9:25   ` [PATCH v8 02/29] thermal/sysfs: Always expose hysteresis attributes Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 03/29] thermal/core: Add a generic thermal_zone_set_trip() function Daniel Lezcano
2022-10-03 11:56     ` Rafael J. Wysocki
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 04/29] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 05/29] thermal/of: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 06/29] thermal/of: Remove unused functions Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 07/29] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 08/29] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 09/29] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 10/29] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 11/29] thermal/drivers/uniphier: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 12/29] thermal/drivers/hisi: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 13/29] thermal/drivers/qcom: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 14/29] thermal/drivers/armada: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 15/29] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 16/29] thermal/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 17/29] thermal/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 18/29] thermal/of: Remove of_thermal_set_trip_hyst() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-10-03 12:50     ` Marek Szyprowski
2022-10-03 12:50       ` Marek Szyprowski
2022-10-03 13:29       ` Daniel Lezcano [this message]
2022-10-03 13:29         ` [PATCH] thermal/drivers/exynos: Fix NULL pointer dereference when getting the critical temp Daniel Lezcano
2022-10-03 13:40         ` Krzysztof Kozlowski
2022-10-03 13:40           ` Krzysztof Kozlowski
2022-10-03 13:50         ` Marek Szyprowski
2022-10-03 13:50           ` Marek Szyprowski
2022-10-17 13:48         ` Marek Szyprowski
2022-10-17 13:48           ` Marek Szyprowski
2022-10-17 14:14           ` Daniel Lezcano
2022-10-17 14:14             ` Daniel Lezcano
2022-10-03 13:31       ` [PATCH v8 19/29] thermal/of: Remove of_thermal_get_crit_temp() Daniel Lezcano
2022-10-03 13:31         ` Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 20/29] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 21/29] thermal/drivers/imx: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 22/29] thermal/drivers/rcar: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 23/29] thermal/drivers/broadcom: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 24/29] thermal/drivers/da9062: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 25/29] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:25   ` [PATCH v8 26/29] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 27/29] thermal/drivers/cxgb4: " Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 28/29] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03  9:26   ` [PATCH v8 29/29] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-12-09 15:26     ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-10-03 14:10   ` [PATCH v8 00/29] Rework the trip points creation Marek Szyprowski
2022-10-03 14:10     ` Marek Szyprowski
2022-10-03 15:36     ` Daniel Lezcano
2022-10-03 15:36       ` Daniel Lezcano
2022-10-03 21:18     ` Daniel Lezcano
2022-10-03 21:18       ` Daniel Lezcano
2022-10-05 12:37       ` Daniel Lezcano
2022-10-05 12:37         ` Daniel Lezcano
2022-10-05 13:05         ` Marek Szyprowski
2022-10-05 13:05           ` Marek Szyprowski
2022-10-06  6:55           ` Daniel Lezcano
2022-10-06  6:55             ` Daniel Lezcano
2022-10-06 16:25             ` Marek Szyprowski
2022-10-06 16:25               ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221003132943.1383065-1-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=amitk@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.