From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EED3C433F5 for ; Mon, 3 Oct 2022 23:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbiJCX5q (ORCPT ); Mon, 3 Oct 2022 19:57:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbiJCX5d (ORCPT ); Mon, 3 Oct 2022 19:57:33 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E9C15722 for ; Mon, 3 Oct 2022 16:57:32 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id r185so2299640pgr.12 for ; Mon, 03 Oct 2022 16:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=UHb21iKAOr0dixbnKvFOpyl+rdeQazDsJI0KUTcj5+g=; b=KpStkDnnuZCV5Ylx+JpcbSSVcZ5VtJEhUFrVM3vKtPMRB8Q2OY9QojiRRJkwtr68xO 78FdHhezN5LHg2lyEeohpeZjvyF+/uATLemjDAhmV66ktRlADy9jiwIKe9pwRbwj5m5y AWYkxxyxNZ3sc1IMKb8B+XVg6xzbZdkYuPpvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=UHb21iKAOr0dixbnKvFOpyl+rdeQazDsJI0KUTcj5+g=; b=yM7fM9QOwoe+nvJK/gE/aj61IqcFyPMSzaa5tryI7bPf9602kB7tYEIa0yEdPxENK3 HXsQTr2woZYSKGDchNAvpC0Ebvm5At6y3wTYY0MKrLWD55PN9/efgYyrAz2WaKc55HZo WX6KlZWSGnK5QVtpNwPk6tJ1rWAB69+f1ArAHdec45f0j9PLMheHgmIjspLa4xBG/xte lbr3LlGAFRNbox38euiznY8a45bS9RZ9HXf2Z+gqtSkR1eHohDNqyxmEEyj1FpuY1N8W d/UZQqD9HRAjzYXeFQ5bDGcGENThiDjdL+Q4EJb8CSUF4KL7wcgObJ0P+mxXY1jOm4hg 6iRg== X-Gm-Message-State: ACrzQf3NAfvE5kVaB11gpKe8neCHcgEkULBMH72+4MIH2evfMzTxUPAp NCD0H5eGCy+WLC86dyTdXQSaog== X-Google-Smtp-Source: AMsMyM4miqD1QvaIAofzYNdJ7PobZDSOM4f6o2pYjvzrBRyiOKLNOKFLm/OFeOKRY5a5vyljxQgJow== X-Received: by 2002:a63:90c1:0:b0:450:75b5:29fe with SMTP id a184-20020a6390c1000000b0045075b529femr5070949pge.541.1664841451616; Mon, 03 Oct 2022 16:57:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k14-20020a6555ce000000b0043057fe66c0sm7263780pgs.48.2022.10.03.16.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 16:57:31 -0700 (PDT) Date: Mon, 3 Oct 2022 16:57:30 -0700 From: Kees Cook To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com Subject: Re: [PATCH v2 33/39] x86/cpufeatures: Limit shadow stack to Intel CPUs Message-ID: <202210031656.23FAA3195@keescook> References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-34-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929222936.14584-34-rick.p.edgecombe@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 03:29:30PM -0700, Rick Edgecombe wrote: > Shadow stack is supported on newer AMD processors, but the kernel > implementation has not been tested on them. Prevent basic issues from > showing up for normal users by disabling shadow stack on all CPUs except > Intel until it has been tested. At which point the limitation should be > removed. > > Signed-off-by: Rick Edgecombe So running the selftests on an AMD system is sufficient to drop this patch? -- Kees Cook