From: Enzo Matsumiya <ematsumiya@suse.de>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cifs: remove initialization value
Date: Tue, 4 Oct 2022 11:23:06 -0300 [thread overview]
Message-ID: <20221004142306.ysgh45nhgdo4z3ok@suse.de> (raw)
In-Reply-To: <20221004062333.416225-1-usama.anjum@collabora.com>
Hi Usama,
On 10/04, Muhammad Usama Anjum wrote:
>Don't initialize the rc as its value is being overwritten before its
>use.
Being bitten by an unitialized variable bug as recent as 2 days ago, I'd
say this is a step backwards from the "best practices" POV.
>Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>---
> fs/cifs/smb2pdu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
>index 0600f0a07628..2bf43c892ae6 100644
>--- a/fs/cifs/smb2pdu.c
>+++ b/fs/cifs/smb2pdu.c
>@@ -879,7 +879,7 @@ SMB2_negotiate(const unsigned int xid,
> struct smb2_negotiate_rsp *rsp;
> struct kvec iov[1];
> struct kvec rsp_iov;
>- int rc = 0;
>+ int rc;
> int resp_buftype;
> int blob_offset, blob_length;
> char *security_blob;
>--
>2.30.2
Cheers,
Enzo
next prev parent reply other threads:[~2022-10-04 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 6:23 [PATCH 1/2] cifs: remove initialization value Muhammad Usama Anjum
2022-10-04 6:23 ` [PATCH 2/2] cifs: check returned value for error Muhammad Usama Anjum
2022-10-04 19:01 ` Paulo Alcantara
2022-10-05 5:17 ` Muhammad Usama Anjum
2022-10-04 14:23 ` Enzo Matsumiya [this message]
2022-10-05 14:13 ` [PATCH 1/2] cifs: remove initialization value David Laight
2022-10-07 19:22 ` 'Enzo Matsumiya'
2022-10-05 14:58 ` Dan Carpenter
2022-10-04 18:59 ` Paulo Alcantara
2022-10-05 7:05 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004142306.ysgh45nhgdo4z3ok@suse.de \
--to=ematsumiya@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pc@cjr.nz \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.