From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: "Vidya Sagar" <vidyas@nvidia.com>,
"Saheed O . Bolarinwa" <refactormyself@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rajat Jain" <rajatja@google.com>,
"Kenneth R . Crudup" <kenny@panix.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Abhishek Sahu" <abhsahu@nvidia.com>,
"Thierry Reding" <treding@nvidia.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Krishna Thota" <kthota@nvidia.com>,
"Manikanta Maddireddy" <mmaddireddy@nvidia.com>,
"Vidya Sagar" <sagar.tv@gmail.com>,
sagupta@nvidia.com, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH 0/3] PCI/ASPM: Fix L1SS issues
Date: Tue, 4 Oct 2022 21:58:06 -0500 [thread overview]
Message-ID: <20221005025809.2247547-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
This is really late, but I think we have two significant issues with L1SS:
1) pcie_aspm_cap_init() reads from the L1SS capability even when it
doesn't exist, so it reads PCI_COMMAND and PCI_STATUS instead and treats
those as an L1SS Capability value.
2) encode_l12_threshold() encodes LTR_L1.2_THRESHOLD as smaller than
requested, so ports may enter L1.2 when they should not.
These patches are intended to fix both issues.
Bjorn Helgaas (3):
PCI/ASPM: Factor out L1 PM Substates configuration
PCI/ASPM: Ignore L1 PM Substates if device lacks capability
PCI/ASPM: Correct LTR_L1.2_THRESHOLD computation
drivers/pci/pcie/aspm.c | 155 +++++++++++++++++++++++-----------------
1 file changed, 90 insertions(+), 65 deletions(-)
--
2.25.1
next reply other threads:[~2022-10-05 2:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 2:58 Bjorn Helgaas [this message]
2022-10-05 2:58 ` [PATCH 1/3] PCI/ASPM: Factor out L1 PM Substates configuration Bjorn Helgaas
2022-10-05 2:58 ` [PATCH 2/3] PCI/ASPM: Ignore L1 PM Substates if device lacks capability Bjorn Helgaas
2022-10-05 3:26 ` Sathyanarayanan Kuppuswamy
2022-10-05 11:07 ` Bjorn Helgaas
2022-10-05 2:58 ` [PATCH 3/3] PCI/ASPM: Correct LTR_L1.2_THRESHOLD computation Bjorn Helgaas
2022-10-05 3:28 ` [PATCH 0/3] PCI/ASPM: Fix L1SS issues Sathyanarayanan Kuppuswamy
2022-10-05 17:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005025809.2247547-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=abhsahu@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kai.heng.feng@canonical.com \
--cc=kenny@panix.com \
--cc=kthota@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rajatja@google.com \
--cc=refactormyself@gmail.com \
--cc=sagar.tv@gmail.com \
--cc=sagupta@nvidia.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.