From: Jakub Kicinski <kuba@kernel.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Raju Rangoju <Raju.Rangoju@amd.com>,
Shyam-sundar.S-k@amd.com, davem@davemloft.net,
netdev@vger.kernel.org, rrangoju@amd.com
Subject: Re: [PATCH net 1/3] amd-xgbe: Yellow carp devices do not need rrc
Date: Thu, 6 Oct 2022 17:26:54 -0700 [thread overview]
Message-ID: <20221006172654.45372b3b@kernel.org> (raw)
In-Reply-To: <7a1b3750-1b3d-a9b9-ebba-3258c90fff7e@amd.com>
On Thu, 6 Oct 2022 09:32:34 -0500 Tom Lendacky wrote:
> On 10/6/22 08:54, Raju Rangoju wrote:
> > Yellow carp devices disables the CDR workaround path,
> > receiver reset cycle is not needed in such cases.
> > Hence, avoid issuing rrc on Yellow carp platforms.
Not entirely clear why this is a Fix, TBH.
What harm comes from doing the reset? You need to describe
the user-observable harm if the patch is a fix.
> > Fixes: 47f164deab22 ("amd-xgbe: Add PCI device support")
>
> That is the wrong Fixes: tag. Yellow Carp support was added with commit
>
> dbb6c58b5a61 ("net: amd-xgbe: Add Support for Yellow Carp Ethernet device")
>
> However, the changes to allow updating the version data were made with
>
> 6f60ecf233f9 ("net: amd-xgbe: Disable the CDR workaround path for Yellow Carp Devices")
>
> so that is the tag most likely needed should you want this to be able to
> go to stable.
FWIW the Fixes tag should point to the commit where the bug is
introduced, not where the patch will apply. The automation will
figure out where it applies.
> With a change to the Fixes: tag:
>
> Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
These devices are only present on SoCs? Changing global data during
probe looks odd.
next prev parent reply other threads:[~2022-10-07 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 13:54 [PATCH net 0/3] amd-xgbe: Miscellaneous fixes Raju Rangoju
2022-10-06 13:54 ` [PATCH net 1/3] amd-xgbe: Yellow carp devices do not need rrc Raju Rangoju
2022-10-06 14:32 ` Tom Lendacky
2022-10-07 0:26 ` Jakub Kicinski [this message]
2022-10-08 18:27 ` Raju Rangoju
2022-10-06 13:54 ` [PATCH net 2/3] amd-xgbe: enable PLL_CTL for fixed PHY modes only Raju Rangoju
2022-10-06 14:47 ` Tom Lendacky
2022-10-06 17:23 ` Raju Rangoju
2022-10-06 13:54 ` [PATCH net 3/3] amd-xgbe: fix the SFP compliance codes check for DAC cables Raju Rangoju
2022-10-06 15:00 ` Tom Lendacky
[not found] ` <9a8552c2-0a23-ea1d-9d1c-56b7a6c75487@amd.com>
2022-10-06 19:04 ` Tom Lendacky
[not found] ` <77d8ea25-3557-cd6f-f732-20a046b29661@amd.com>
2022-10-07 14:27 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006172654.45372b3b@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rrangoju@amd.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.