All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: b4 v0.10.1 is available
Date: Fri, 7 Oct 2022 14:11:23 -0400	[thread overview]
Message-ID: <20221007181123.xnc2ihmbmefk5q2x@nitro.local> (raw)
In-Reply-To: <CAL_JsqJVY5Mk0e+wLXQBJnY0OwR=vh24MhqTqmaozBjaBAULKQ@mail.gmail.com>

On Tue, Oct 04, 2022 at 02:03:08PM -0500, Rob Herring wrote:
> I found a couple of issues with trailers and send. I'm on the current master.
> 
> In 'b4 trailers', if the patch id doesn't match exactly and it finds
> some trailers, b4 just prints 'No trailer updates found.' which is
> misleading. Can it have a fallback to subject matching or at least
> print when there isn't an exact match and list the trailers found.

Strange, I thought we already did fall back to subject matching when we
couldn't match by patch-id. I'll work to set up a couple of testcases so we
can easily identify such regressions (if that's what it is) in the future.

> It's quite common to either have minor changes (and a judgement call
> on whether tags still apply) or a review that's 'With X fixed,
> Reviewed-by: ...".
> 
> The 2nd issue is with 'b4 send' and seems to have been introduced
> recently. I have a commit msg like this:
> "
> Some commit
> 
> Signed-off-by: ...
> ---
>  v2: https://lore.kernel.org/all/20220909204509.2169512-1-robh@kernel.org/
>    - Rework YACC code to handle configN formats in C code
>    - Add a warning when an unknown configN attr is found
> "
> 
> I'm putting '---' in the commit to store the changes for the commit.
> The patch ends up with 2 '---' lines, but git drops everything after
> the first one. The issue is that
> '//lore.kernel.org/all/20220909204509.2169512-1-robh@kernel.org/' is
> added to the Cc list.

Thank you for the report -- I wasn't expecting to find changelog entries in
the commits, so I'll add that to tests as well and fix it up.

-K

  reply	other threads:[~2022-10-07 18:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 17:29 b4 v0.10.1 is available Konstantin Ryabitsev
2022-10-04 19:03 ` Rob Herring
2022-10-07 18:11   ` Konstantin Ryabitsev [this message]
2022-10-27 19:38   ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221007181123.xnc2ihmbmefk5q2x@nitro.local \
    --to=konstantin@linuxfoundation.org \
    --cc=robh@kernel.org \
    --cc=tools@linux.kernel.org \
    --cc=users@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.