Re: [PATCH v5 0/6] add thread lifetime and attributes API

[Tyler Retzlaff <roretzla@linux.microsoft.com>]

thanks David,

appreciate it. it's nice to finally get this series cleared.

On Thu, Oct 06, 2022 at 09:25:12PM +0200, David Marchand wrote:
> On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > add rte thread lifetime and attributes api. with these api additions
> > there is now sufficient platform abstracted thread api to remove the
> > use of pthread in the unit tests.
> >
> > v5:
> >   * include errno.h in rte_thread.c since errno.h is no longer included
> >     in rte_common.h
> >   * move rte_thread_attr symbols from 22.07 to 22.11 section of
> >     version.map.
> >   * remove RTE_HAS_CPUSET guards from rte_thread.h
> 
> Here is a summary of what I did:
> - I had to rollback part of RTE_HAS_CPUSET guards.
> I had forgotten about the reason for those guards: the "culprit" is
> Alpine Linux / musl where cpuset is not exposed unless an application
> is built with _GNU_SOURCE.
> See: https://git.dpdk.org/dpdk/commit/lib/librte_eal/include/rte_thread.h?id=e0473c6d5b18560dd11fd4d7ebc81dea6774f33e
> - I squashed patch 6 in patch 4 to fix the compilation.
> - I moved rte_thread.c content to eal_common_thread.c.
> - I still added Dmitry acks from v4, as the functional parts/API did not change.
> 
> 
> Series applied, thanks.
> 
> 
> -- 
> David Marchand