From: Daniel Wagner <dwagner@suse.de>
To: Alan Adamson <alan.adamson@oracle.com>
Cc: Pankaj Raghav <pankydev8@gmail.com>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
Keith Busch <kbusch@kernel.org>, Yi Zhang <yi.zhang@redhat.com>,
Tomas Bzatek <tbzatek@redhat.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Martin Petersen <martin.petersen@oracle.com>,
"gost.dev@samsung.com" <gost.dev@samsung.com>,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v1] nvme: do not log errors for user commands
Date: Mon, 10 Oct 2022 09:36:04 +0200 [thread overview]
Message-ID: <20221010073604.rryji23gnnxgoqrr@carbon.lan> (raw)
In-Reply-To: <35A47E59-90E0-4F6C-80EA-A98F59213FA0@oracle.com>
Hi Alan,
On Fri, Oct 07, 2022 at 09:19:08PM +0000, Alan Adamson wrote:
> > I do get the debugging argument, but this clearly regresses production
> > code. Ideally, this code should be opt-in. The only way I see how to make
> > this work is by introducing a new API which allows enable this
> > feature.
>
> Looks like a new API may need to be created. I’ll investigate that.
> With your change, there will need to be a blktests change.
Thanks for picking this up.
> nvme/039 => nvme0n1 (test error logging) [failed]
> runtime 0.120s ... 0.118s
> --- tests/nvme/039.out 2022-09-21 17:14:12.760890663 -0400
> +++ /root/blktests/results/nvme0n1/nvme/039.out.bad 2022-10-06 19:11:45.846879996 -0400
> @@ -2,6 +2,4 @@
> Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
> Read(0x2) @ LBA 0, 1 blocks, Unknown (sct 0x3 / sc 0x75) DNR
> Write(0x1) @ LBA 0, 1 blocks, Write Fault (sct 0x2 / sc 0x80) DNR
> - Identify(0x6), Access Denied (sct 0x2 / sc 0x86) DNR
> - Unknown(0x96), Invalid Command Opcode (sct 0x0 / sc 0x1) DNR
> Test complete
Hmm, that is not supposed to happen. Well, obviously this needs some
more work :)
Thanks,
Daniel
next prev parent reply other threads:[~2022-10-10 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:36 [PATCH v1] nvme: do not log errors for user commands Daniel Wagner
2022-10-06 12:16 ` Pankaj Raghav
2022-10-06 13:30 ` Daniel Wagner
2022-10-07 21:19 ` Alan Adamson
2022-10-10 7:36 ` Daniel Wagner [this message]
2022-10-17 7:07 ` Christoph Hellwig
2022-10-17 16:37 ` Keith Busch
2022-10-17 16:40 ` Alan Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010073604.rryji23gnnxgoqrr@carbon.lan \
--to=dwagner@suse.de \
--cc=alan.adamson@oracle.com \
--cc=gost.dev@samsung.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=tbzatek@redhat.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.