From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F36A0C433F5 for ; Mon, 10 Oct 2022 16:28:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 02EC284E4F; Mon, 10 Oct 2022 18:28:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="U9+ShllV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE1D184D8E; Mon, 10 Oct 2022 18:28:24 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C0A7084E4F for ; Mon, 10 Oct 2022 18:28:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id x25so3325298qki.2 for ; Mon, 10 Oct 2022 09:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t0mLQnA7bgso45IA9g2KjIJvL6pjzbNNUVS9HxTVY8w=; b=U9+ShllVI2X8+mT8pddq4dsQn8Mq5fWyQMnV+6i9zWkHN1sOmCaemkSFjBlC0pzBsM dSK7dvTQ09zo073crkeibVdwUiWBjUuiu6GUQzlB5k+0+dkANrpNhnWj/KdnwZZPRnpr 9hj+iQm9QXlnsFTiNGzS9BTYz7hMnTArl40Lg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t0mLQnA7bgso45IA9g2KjIJvL6pjzbNNUVS9HxTVY8w=; b=KkwnskPZ7d1fbqaBBuHBB+OJ5twLrl+px9MfZ+0AlIo1hpfvae6VUPWYLccLmz63h8 L47KH1eV4nJF2lT3ikdqWx1sYl76MZvWFpZ1S6j1hkTsO3U27H9bgwCPBtJPI+J60pRN fVvmfPMiMwjdU2cxthNqoGerLGDg/GGbnivfslvn90AudYGsen8da9XH7Rs+Yv4hql8P Q2hB1N3CqnMlOkSqE5G1GL3PRl3byPk+g4LUeZa5EQAEj/tG8+sgGJPU6ZU1tFeppYON XplVTNWfNwdgCa/d1QcpL/lz2Xi+PajOXpkU3EcqueSv7/UpGLzC+X63EYtkvy+rE78B vl+g== X-Gm-Message-State: ACrzQf11MooODzUnfGSi3khpmTVhWbclYWexFn+OGHYxa1Yd3GwJ4J+Q BSxwthygc2F/O2QBSB8N2UdLqg== X-Google-Smtp-Source: AMsMyM5N7NktqJ9h0Ey2kJkyKYiR6PPr10WT3DuWVNQE1Uejifw/Rkkm2cw7Hl9MGl022dww22OFzw== X-Received: by 2002:a05:620a:4807:b0:6cf:55d:e4c3 with SMTP id eb7-20020a05620a480700b006cf055de4c3mr13468183qkb.563.1665419300533; Mon, 10 Oct 2022 09:28:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-9534-07b5-32fb-791d.res6.spectrum.com. [2603:6081:7b00:6400:9534:7b5:32fb:791d]) by smtp.gmail.com with ESMTPSA id bn35-20020a05620a2ae300b006ce60296f97sm10134000qkb.68.2022.10.10.09.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 09:28:19 -0700 (PDT) Date: Mon, 10 Oct 2022 12:28:18 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= , Stefan Roese Cc: u-boot@lists.denx.de Subject: Re: Broken watchdog in u-boot master branch Message-ID: <20221010162818.GM2020586@bill-the-cat> References: <20221009191225.65jwebefhqng3qbi@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WR+jf/RUebEcofwt" Content-Disposition: inline In-Reply-To: <20221009191225.65jwebefhqng3qbi@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --WR+jf/RUebEcofwt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 09, 2022 at 09:12:25PM +0200, Pali Roh=E1r wrote: > Hello! Watchdog code seems to be broken in u-boot master branch. > On Nokia N900 I'm getting following message in qemu: >=20 > cyclic function rx51_watchdog took too long: 10000us vs 1000us max, disab= ling >=20 > Seems that watchdog core code is not prepared for "slower" watchdogs > which communicate over slower i2c bus, like it is the case for N900. >=20 > Disabling slower watchdog is a bad idea as it would result in reboot > loop instead of slower - but working code. So, looking at this in more detail, we have CONFIG_CYCLIC_MAX_CPU_TIME_US as a configuration option (which is where the too long comes from). And picking a random CI run: https://source.denx.de/u-boot/u-boot/-/jobs/511177 I do see we hit this in CI once, but not every time, QEMU runs here. Is that the max time is configurable enough to satisfy your concerns here? --=20 Tom --WR+jf/RUebEcofwt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNESCIACgkQFHw5/5Y0 tyynLQv/Ul/A71tiob80zWvixXUt+Ki9T48cqZ+1v+AJhYPwRLwlNBVJDHgYVtGx brtJ/Thos+Veep0CQW+qJ9F3qVWTcZa9ZLwbAwRUMLvdrRcYLqEa+XG9YzbACzrX alMeisuhEXz7Xu9nyoLrUKtNXTnkOmumgNzMjgruDNLipPZyicab0356sh/SiEPE Q2Z1e/rUQFQ+JkkfHSEXOlmgFVmJQWRZOwJ0byjbVO80LfTSHSj8o1LW5Wm1vBsQ LY6qLX8atlrPJeDGt5M9AuBiMvHnBk8VX/yXUAVE9AujgzK/2e5/biK//s4Idkj4 KJ/rIKlPxu00paJiwvR83fRIeCwVUf3fBVKG9aS2q16uMrDGFwskh9ginxw2Dl95 XxDNXzB0f8L0Refj7NZwel/zuy4n1zpLd05BBsOl3w5yDqRjskLpwLSg60Uhqupe JO6SGWzvkhrCVylt8FVI67PjrUnw6ITpqz00JXOPRZRxbVpnSQqcToB6HMPmd/gR Xhg5Q0nZ =K9RS -----END PGP SIGNATURE----- --WR+jf/RUebEcofwt--