From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A089C433F5 for ; Mon, 10 Oct 2022 17:44:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E9E184ED8; Mon, 10 Oct 2022 19:44:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="q4DghqP2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DF28984EE9; Mon, 10 Oct 2022 19:44:12 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1D59784ED8 for ; Mon, 10 Oct 2022 19:44:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1434B81055; Mon, 10 Oct 2022 17:44:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35BC7C433C1; Mon, 10 Oct 2022 17:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665423848; bh=QvSxryp6oumnWljjy6oAw/lqTy+bVAINFbsB8uouxws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q4DghqP24qN29JrWGtbpXFRP24mVOdrb/sLMjCCZ+S8X7cNoUNXoYy/9xoYg1q5pE FK9BECk4ijcJCOHsm2LI86ZXf2TZgx5hDYzh8io6wC8vxjSsPhWECH7ZvdbDAzvYsA BxKQNu69+jPWQ2xZ8amMaBErFFy2/cpU44L0jedEDT/osN9ABRXLI9EHNPJ9QpuOK/ w+/ZSBZFaoC5v3DotDHL4+yVCxsSwjnel6pXkoZjLPS3hC3T7abnEQioL4zH5w1bc9 WsTzxF91amqo6mIIOgKoPEi+Mz0z9Ho+tLFz607CQ00TnIgifxJyJRfEt9/6eaW9XU 4Z9MG0CC6/+wg== Received: by pali.im (Postfix) id 8FC177F9; Mon, 10 Oct 2022 19:44:05 +0200 (CEST) Date: Mon, 10 Oct 2022 19:44:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: Broken watchdog in u-boot master branch Message-ID: <20221010174405.5rvz7aclukn567gj@pali> References: <20221009191225.65jwebefhqng3qbi@pali> <20221010162818.GM2020586@bill-the-cat> <20221010172256.jb4qwvgsbcucwejf@pali> <20221010174038.GP2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221010174038.GP2020586@bill-the-cat> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Monday 10 October 2022 13:40:38 Tom Rini wrote: > On Mon, Oct 10, 2022 at 07:22:56PM +0200, Pali Rohár wrote: > > On Monday 10 October 2022 12:28:18 Tom Rini wrote: > > > On Sun, Oct 09, 2022 at 09:12:25PM +0200, Pali Rohár wrote: > > > > Hello! Watchdog code seems to be broken in u-boot master branch. > > > > On Nokia N900 I'm getting following message in qemu: > > > > > > > > cyclic function rx51_watchdog took too long: 10000us vs 1000us max, disabling > > > > > > > > Seems that watchdog core code is not prepared for "slower" watchdogs > > > > which communicate over slower i2c bus, like it is the case for N900. > > > > > > > > Disabling slower watchdog is a bad idea as it would result in reboot > > > > loop instead of slower - but working code. > > > > > > So, looking at this in more detail, we have > > > CONFIG_CYCLIC_MAX_CPU_TIME_US as a configuration option (which is where > > > the too long comes from). And picking a random CI run: > > > https://source.denx.de/u-boot/u-boot/-/jobs/511177 > > > I do see we hit this in CI once, but not every time, QEMU runs here. Is > > > that the max time is configurable enough to satisfy your concerns here? > > > > It is needed to investigate, how to _properly_ fix this issue, not just > > workarounded it. Probably other boards may be affected. > > So it's the cyclic watchdog code, which we merged as early as possible > that's the reason here. And it was merged as early as we could to see if > there's problems. Are there problems? We're seeing "system too slow, > disabling" on QEMU, sometimes, and the value of too slow is > configurable. I know you reported other problems with n900 HW, so we > can't see if it's failing there I was tested it with older asm code (as described in that other email, via git checkout commit -- file) on n900 HW and watchdog problem is there too. Phone reboots in about 20 seconds. But as I do not have serial console, I do not know if that "disabling" message is printed there too (but I guess it is). > and I don't have any omap3 HW setup in > my lab atm, just newer generation boards and don't see the problem > there. Which is why I'm asking, is being able to configure the "too > slow" value enough? Or is there something else that needs to be done?