From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF478C4332F for ; Thu, 13 Oct 2022 07:49:53 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1356742C94; Thu, 13 Oct 2022 09:49:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1BD1742C27 for ; Thu, 13 Oct 2022 09:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665647390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iDH6OFj5TFsY9k3pB8oHnEl3s0/P2TIJ2DngtZYk3qk=; b=a7K5cAhB2mSs6hYoWBJ9EzRmaTlLoDOflg7BWmabzkILZRCHnObFz2r3qcNvraWxMOX0di LBuBUiP/CIdi+5/rFdzxy3toDlE6cxRM3XdxHZQtoMkoa5JlOUtZEv/N2eDnRIJhv/d/l6 G5NsnUaIGcp6fJizjNKC93M2JYjDwcU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-p_zCZbo2OS6S1ZyImaC7dQ-1; Thu, 13 Oct 2022 03:49:46 -0400 X-MC-Unique: p_zCZbo2OS6S1ZyImaC7dQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 630AA29AA38A; Thu, 13 Oct 2022 07:49:46 +0000 (UTC) Received: from localhost.localdomain (ovpn-193-115.brq.redhat.com [10.40.193.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46A901759E; Thu, 13 Oct 2022 07:49:45 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: bruce.richardson@intel.com, Jerin Jacob , Sunil Kumar Kori , Ciara Power Subject: [PATCH] trace: take live traces via telemetry Date: Thu, 13 Oct 2022 09:49:28 +0200 Message-Id: <20221013074928.3062458-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Register telemetry commands to list and configure trace points and later save traces for a running DPDK application. Note: trace point names contain a '.', so the list of valid characters used in telemetry commands and dictionary keys has been extended. Example with testpmd running with two net/null ports (startup command from devtools/test-null.sh): --> /trace/list,lib.ethdev.* {"/trace/list": {"lib.ethdev.configure": "Disabled", "lib.ethdev.rxq.setup": "Disabled", "lib.ethdev.txq.setup": "Disabled", "lib.ethdev.start": "Disabled", "lib.ethdev.stop": "Disabled", "lib.ethdev.close": "Disabled", "lib.ethdev.rx.burst": "Disabled", "lib.ethdev.tx.burst": "Disabled"}} --> /trace/enable,lib.ethdev.st* {"/trace/enable": {"Count": 2}} --> /trace/enable,lib.ethdev.st* {"/trace/enable": {"Count": 0}} --> /trace/list,lib.ethdev.* {"/trace/list": {"lib.ethdev.configure": "Disabled", "lib.ethdev.rxq.setup": "Disabled", "lib.ethdev.txq.setup": "Disabled", "lib.ethdev.start": "Enabled", "lib.ethdev.stop": "Enabled", "lib.ethdev.close": "Disabled", "lib.ethdev.rx.burst": "Disabled", "lib.ethdev.tx.burst": "Disabled"}} testpmd> stop ... testpmd> port stop all ... testpmd> port start all ... testpmd> start ... --> /trace/save {"/trace/save": {"Status": "OK", "Path": ".../dpdk-traces/rte-2022-10-12-AM-10-51-48"}} $ babeltrace .../dpdk-traces/rte-2022-10-12-AM-10-51-48 [10:51:36.229878723] (+?.?????????) lib.ethdev.stop: { cpu_id = 0x0, name = "dpdk-testpmd" }, { port_id = 0x0, ret = 0 } [10:51:36.229880251] (+0.000001528) lib.ethdev.stop: { cpu_id = 0x0, name = "dpdk-testpmd" }, { port_id = 0x1, ret = 0 } [10:51:40.449359774] (+4.219479523) lib.ethdev.start: { cpu_id = 0x0, name = "dpdk-testpmd" }, { port_id = 0x0 } [10:51:40.449377877] (+0.000018103) lib.ethdev.start: { cpu_id = 0x0, name = "dpdk-testpmd" }, { port_id = 0x1 } --> /trace/disable,* {"/trace/disable": {"Count": 2}} Signed-off-by: David Marchand --- For runtime testing, please use this patch in addition with series 25183. Depends-on: series-25183 ("Trace subsystem fixes") --- lib/eal/common/eal_common_trace.c | 78 +++++++++++++++++++++++++++++++ lib/telemetry/telemetry_data.c | 1 + 2 files changed, 79 insertions(+) diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c index f9b187d15f..9a54987b42 100644 --- a/lib/eal/common/eal_common_trace.c +++ b/lib/eal/common/eal_common_trace.c @@ -12,6 +12,7 @@ #include #include #include +#include #include "eal_trace.h" @@ -530,3 +531,80 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name, return -rte_errno; } + +static int +trace_telemetry_enable(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + unsigned int count; + + if (params == NULL || strlen(params) == 0) + return -1; + rte_tel_data_start_dict(d); + count = __atomic_load_n(&trace.status, __ATOMIC_RELAXED); + rte_trace_pattern(params, true); + rte_tel_data_add_dict_int(d, "Count", + __atomic_load_n(&trace.status, __ATOMIC_RELAXED) - count); + return 0; + +} + +static int +trace_telemetry_disable(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + unsigned int count; + + if (params == NULL || strlen(params) == 0) + return -1; + rte_tel_data_start_dict(d); + count = __atomic_load_n(&trace.status, __ATOMIC_RELAXED); + rte_trace_pattern(params, false); + rte_tel_data_add_dict_int(d, "Count", + count - __atomic_load_n(&trace.status, __ATOMIC_RELAXED)); + return 0; + +} + +static int +trace_telemetry_list(const char *cmd __rte_unused, + const char *params, struct rte_tel_data *d) +{ + struct trace_point *tp; + + rte_tel_data_start_dict(d); + STAILQ_FOREACH(tp, &tp_list, next) { + if (params != NULL && fnmatch(params, tp->name, 0) != 0) + continue; + + rte_tel_data_add_dict_string(d, tp->name, + rte_trace_point_is_enabled(tp->handle) ? "Enabled" : "Disabled"); + } + + return 0; +} + +static int +trace_telemetry_save(const char *cmd __rte_unused, + const char *params __rte_unused, struct rte_tel_data *d) +{ + struct trace *trace = trace_obj_get(); + + rte_tel_data_start_dict(d); + rte_tel_data_add_dict_string(d, "Status", rte_trace_save() == 0 ? "OK" : "KO"); + rte_tel_data_add_dict_string(d, "Path", trace->dir); + + return 0; +} + +RTE_INIT(trace_telemetry) +{ + rte_telemetry_register_cmd("/trace/enable", trace_telemetry_enable, + "Enable trace points matching the provided pattern. Parameters: string pattern."); + rte_telemetry_register_cmd("/trace/disable", trace_telemetry_disable, + "Disable trace points matching the provided pattern. Parameters: string pattern."); + rte_telemetry_register_cmd("/trace/list", trace_telemetry_list, + "List trace points. Parameters: string pattern."); + rte_telemetry_register_cmd("/trace/save", trace_telemetry_save, + "Save current traces. Takes no parameter."); +} diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c index 34366ecee3..5b319c18fb 100644 --- a/lib/telemetry/telemetry_data.c +++ b/lib/telemetry/telemetry_data.c @@ -106,6 +106,7 @@ valid_name(const char *name) ['a' ... 'z'] = 1, ['_'] = 1, ['/'] = 1, + ['.'] = 1, }; while (*name != '\0') { if ((size_t)*name >= RTE_DIM(allowed) || allowed[(int)*name] == 0) -- 2.37.3