From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8239CC433FE for ; Fri, 14 Oct 2022 04:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229507AbiJNEuz (ORCPT ); Fri, 14 Oct 2022 00:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbiJNEuy (ORCPT ); Fri, 14 Oct 2022 00:50:54 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D3B5B2B24A for ; Thu, 13 Oct 2022 21:50:52 -0700 (PDT) Received: from dread.disaster.area (pa49-181-106-210.pa.nsw.optusnet.com.au [49.181.106.210]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 2619A8AD9A8; Fri, 14 Oct 2022 15:50:52 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ojCeo-001kld-W8; Fri, 14 Oct 2022 15:50:51 +1100 Date: Fri, 14 Oct 2022 15:50:50 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/6] xfs: teach scrub to check for adjacent bmaps when rmap larger than bmap Message-ID: <20221014045050.GO3600936@dread.disaster.area> References: <166473480864.1083927.11062319917293302327.stgit@magnolia> <166473480901.1083927.9138933758527320078.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <166473480901.1083927.9138933758527320078.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=6348eaac a=j6JUzzrSC7wlfFge/rmVbg==:117 a=j6JUzzrSC7wlfFge/rmVbg==:17 a=kj9zAlcOel0A:10 a=Qawa6l4ZSaYA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=RDDF6AJK-s76zwRZyVMA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sun, Oct 02, 2022 at 11:20:09AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > When scrub is checking file fork mappings against rmap records and > the rmap record starts before or ends after the bmap record, check the > adjacent bmap records to make sure that they're adjacent to the one > we're checking. This helps us to detect cases where the rmaps cover > territory that the bmaps do not. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/scrub/bmap.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 72 insertions(+), 2 deletions(-) Looks OK. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com