From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79439C433FE for ; Fri, 14 Oct 2022 15:34:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 170C884B67; Fri, 14 Oct 2022 17:34:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YZdtfeHl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 314F084B67; Fri, 14 Oct 2022 17:34:51 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E9D238456E for ; Fri, 14 Oct 2022 17:34:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id bb5so3858251qtb.11 for ; Fri, 14 Oct 2022 08:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2NagS6aUnXKbJ348Fss/JlZF/zvfGQpfoGqCIoTa6yE=; b=YZdtfeHl/MyzuLNv+Zb3pBvkCtw5C8Dd4xY92B0G1mwM0kUYfktcDeltZjUJ4FMqEG 67O6EFM8azAyx8RD9tBqag1784tshatbKBcL3RwrvASY/cHpuORMKmkswY1/FBIoBEkD YPMauNDzqZ8L2aFpJ7DYS+X/7o1qjX7YX+JX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2NagS6aUnXKbJ348Fss/JlZF/zvfGQpfoGqCIoTa6yE=; b=OvwHlczsDsM/TdWPOi/TSh1bbEC7Zu+2aqnTBosYYtI0/C91luNOlXuCbxLMCYGKSJ AsJEtdeAG6Gk75H9Fj+A//us4ucWkuRKKL1fP73lttZRegn9/rkhs9Jqd4sZJ3MmmE+z NIuSvwyPZgA5qv3p++31rrGXWMetYiycZ/da20PEov/kbmoDMBGVFjZzsTJzrN3k6kq+ QHW1fMvlxUPNkQvHd6HoOG7Wff4soRXwKsojx/BTPbdFkChyIFHXy8m1X0V/nK8Q1wGV 4V/nuAK5OdPJuxlWN4ln2R4WoYVLXYwAC24bmfEz6Z6ILe9Zp3WZolIGnMRpeGvOWoBH mFpA== X-Gm-Message-State: ACrzQf23SRFVpgXYb9hJxQemFZrLYa/FBANwWY/F0GnIGnCZyoiepZv7 UNQP7ZeoC6SRt3gdRfNOH8EmuA== X-Google-Smtp-Source: AMsMyM63e6cgwMTpA6teLrdLeHV6ZY7wym4o0WZcn2NBmq/6J2DFZnLOLaE4hkV19m8lgQI7QzdFWw== X-Received: by 2002:ac8:584c:0:b0:35c:ceee:197a with SMTP id h12-20020ac8584c000000b0035cceee197amr4664533qth.662.1665761686744; Fri, 14 Oct 2022 08:34:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id w6-20020a05620a148600b006bb0f9b89cfsm2485596qkj.87.2022.10.14.08.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 08:34:46 -0700 (PDT) Date: Fri, 14 Oct 2022 11:34:44 -0400 From: Tom Rini To: Jan Kiszka Cc: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf , Simon Glass Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014153444.GU2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014152029.GT2020586@bill-the-cat> <45c70284-f293-3e00-4281-e46ca04b849d@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BX5bBAwwbKvz0cyO" Content-Disposition: inline In-Reply-To: <45c70284-f293-3e00-4281-e46ca04b849d@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --BX5bBAwwbKvz0cyO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: > On 14.10.22 17:20, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > >> On 10/14/22 13:51, Jan Kiszka wrote: > >>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > >>>> On 9/25/21 2:30 AM, Simon Glass wrote: > >>>>> This code should never have been added as it builds a new feature o= n top > >>>>> of legacy code. This has already been improved with the dependency = on > >>>>> BLK. > >>>>> > >>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this= old > >>>>> code. > >>>>> > >>>>> Boards which want EFI_LOADER should migrate to driver model first. > >>>>> > >>>>> Note this patch is included to resolve the following build error: > >>>>> > >>>>> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_TEX= T_BASE=E2=80=99 > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0undeclared (first use in this function); d= id you mean > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > >>>>> =C2=A0=C2=A0 680 |=C2=A0=C2=A0 ulong base =3D CONFIG_SYS_TEXT_BASE; > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~= ~~~~~~~~~ > >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CONFIG_SYS_= SRAM_BASE > >>>>> > >>>>> Signed-off-by: Simon Glass > >>>> > >>>> Reviewed-by: Heinrich Schuchardt > >>>> > >>> > >>> How to deal with boards that need CONFIG_NET but do not actually > >>> implement any driver (yet)? This now broke UEFI for the IOT2050 which > >>> needs NET for network-related device tree setup (see also [1]) and > >>> enforces a local hack for us. > >> > >> UEFI will not provide network without a DM driver. > >> The migration period ended 2020.07. > >> > >> make iot2050_defconfig set EFI_LOADER=3Dy. > >> What does not work in UEFI? > >> > >> Are you missing a way to call eth_get_dev() to trigger aforementioned > >> devicetree setup? > >> > >> Adding 'net list' to CONFIG_PREBOOT might do the trick. > >=20 > > I think, and this is why I suggested NETDEVICES, the issue is that there > > is no network driver in U-Boot, but we need to have networking support > > enabled in general, in order to perform device tree fixups for Linux > > where there is the network driver. > >=20 >=20 > Exactly. >=20 > Unfortunately, NETDEVICES does not do the trick because it selects > DM_ETH anyway, thus you don't detect legacy network drivers this way. Right, but does your platform enable NETDEVICES? It sounds like it shouldn't be since you don't have devices in U-Boot? Or something else? --=20 Tom --BX5bBAwwbKvz0cyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJgZAACgkQFHw5/5Y0 tyz6Gwv+MvM90i4YQG3sFPNIGFuibQasNnWaEb6bjSpRQIVfTh6+Ca3bf29z1C9k iuaM2cNJZ6bt31RuzxSHwrypClPs1it57A9mnlPM3cQoEnAIFa9QhU0wnVe66Bq/ uzq7yRUL/eXRIaEq1Ta3RYqU9uZA1aqKpddK7l5XNBJ7DvbNYhHtr3OY+RZdjDp5 kvM0tXlDHY25rmLK92aXHKi4ibmQgoxJuTeATfZwEhUygpKtoz0X25pmdITzrWJm eLwMwb67Tdaa7neNK2xucTfvvDYGdq+YIZT5eOy7Pku0o56nTOF5iRXDfFNBl2mm gyZs5iBx61WqD5a8sr0PjJdzGEglNIm32qeKXpogybkvzKhsvXiBgSZYdDKrc0qG ddiFZNnFyicz0lu/9loM8GIjERZ30oFy3fDp/EpHGGPlVmJFe/kH2hTQZkEAI/hI X60v3dHr8rtqN2vhL9AlVV3WrUj4y5uIG3CuelzOyef7BoOkprWkXBtD/oMhWLFm PRBy6o/v =P0tl -----END PGP SIGNATURE----- --BX5bBAwwbKvz0cyO--