From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B31AAC4332F for ; Fri, 14 Oct 2022 15:38:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B791D84EA8; Fri, 14 Oct 2022 17:38:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BktBdbI2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E52F684E06; Fri, 14 Oct 2022 17:38:48 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BD67A84EA8 for ; Fri, 14 Oct 2022 17:38:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id f8so2696888qkg.3 for ; Fri, 14 Oct 2022 08:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mB2rLtFDfH1sx5Dvr3piVFlTr4hpPA2JGhmzKxExiT8=; b=BktBdbI2cfG274SgzQ04pYp4VV3c9u9Yt4lWOlNrwqOY3hET4goA6zvi/gTMcy/bp5 Qbs2YlXB4b8u5Gikyeni56Bj8Tf/Bwttjo6eAWqg+PDyEzW30swsMwEssAAQe/FFdxeo 8ZZNK0GknmhXFrvAR1RygJly3j3tf/422t7As= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mB2rLtFDfH1sx5Dvr3piVFlTr4hpPA2JGhmzKxExiT8=; b=6/zZ06FLfsXtZ6tKvgnklBcfwD2T1B1afkDa6djzSplIMsebfZMTIRXz6Y+1PNJbb2 Wpn+ySNWDq/q8Ke+40EnaTHGuDAyzden32+iNUfHXYnGCUhQ4kS4lgvPijjTbY3WTcof PtMCNuy7m0iQgsaIot0K4BJ3vVg/3iGGUP0uYHCG4IzErSp1VJicCLQCUqjGOwfvWJ4o JNGQbgc9AwFA8hS1y1EByxlasiZP0KemGwhTUjmuUq+27kyi9MgOqyYcgekvearsJavO afrM1bVqJ7Of1XtmBTghhdCfO48ARX8aAYc/pnAD6BJAIuVxWhaRJnJ3m0RZUleMytd3 cq3w== X-Gm-Message-State: ACrzQf0ZBzJHprja6pfn2gQRes5Cq0Ij02451xIqr658clgZCYDvBtKD s2AmpCdFlGNXJkWCnFIsjltonQ== X-Google-Smtp-Source: AMsMyM6DHE0U+6Enegif059/8ZjQXpHhRZL6GOWkw8VL8GdQ9xcvf/ZbfrypNM+dw4F0X3bApbN3aQ== X-Received: by 2002:a05:620a:4042:b0:6ec:2550:47ef with SMTP id i2-20020a05620a404200b006ec255047efmr4112876qko.442.1665761924635; Fri, 14 Oct 2022 08:38:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id s13-20020a05620a0bcd00b006cbc00db595sm2683067qki.23.2022.10.14.08.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 08:38:44 -0700 (PDT) Date: Fri, 14 Oct 2022 11:38:42 -0400 From: Tom Rini To: Jan Kiszka Cc: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf , Simon Glass Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014153842.GV2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014152029.GT2020586@bill-the-cat> <45c70284-f293-3e00-4281-e46ca04b849d@siemens.com> <20221014153444.GU2020586@bill-the-cat> <93359f56-b4c8-586d-ea77-cff9808d2e4b@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z5HJNHpVrs9F5Roc" Content-Disposition: inline In-Reply-To: <93359f56-b4c8-586d-ea77-cff9808d2e4b@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --z5HJNHpVrs9F5Roc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 05:35:43PM +0200, Jan Kiszka wrote: > On 14.10.22 17:34, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: > >> On 14.10.22 17:20, Tom Rini wrote: > >>> On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: > >>>> On 10/14/22 13:51, Jan Kiszka wrote: > >>>>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > >>>>>> On 9/25/21 2:30 AM, Simon Glass wrote: > >>>>>>> This code should never have been added as it builds a new feature= on top > >>>>>>> of legacy code. This has already been improved with the dependenc= y on > >>>>>>> BLK. > >>>>>>> > >>>>>>> Add a dependency on DM_ETH also, to avoid needing to deal with th= is old > >>>>>>> code. > >>>>>>> > >>>>>>> Boards which want EFI_LOADER should migrate to driver model first. > >>>>>>> > >>>>>>> Note this patch is included to resolve the following build error: > >>>>>>> > >>>>>>> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_T= EXT_BASE=E2=80=99 > >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0undeclared (first use in this function);= did you mean > >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > >>>>>>> =C2=A0=C2=A0 680 |=C2=A0=C2=A0 ulong base =3D CONFIG_SYS_TEXT_BA= SE; > >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~= ~~~~~~~~~~~~ > >>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CONFIG_S= YS_SRAM_BASE > >>>>>>> > >>>>>>> Signed-off-by: Simon Glass > >>>>>> > >>>>>> Reviewed-by: Heinrich Schuchardt > >>>>>> > >>>>> > >>>>> How to deal with boards that need CONFIG_NET but do not actually > >>>>> implement any driver (yet)? This now broke UEFI for the IOT2050 whi= ch > >>>>> needs NET for network-related device tree setup (see also [1]) and > >>>>> enforces a local hack for us. > >>>> > >>>> UEFI will not provide network without a DM driver. > >>>> The migration period ended 2020.07. > >>>> > >>>> make iot2050_defconfig set EFI_LOADER=3Dy. > >>>> What does not work in UEFI? > >>>> > >>>> Are you missing a way to call eth_get_dev() to trigger aforementioned > >>>> devicetree setup? > >>>> > >>>> Adding 'net list' to CONFIG_PREBOOT might do the trick. > >>> > >>> I think, and this is why I suggested NETDEVICES, the issue is that th= ere > >>> is no network driver in U-Boot, but we need to have networking support > >>> enabled in general, in order to perform device tree fixups for Linux > >>> where there is the network driver. > >>> > >> > >> Exactly. > >> > >> Unfortunately, NETDEVICES does not do the trick because it selects > >> DM_ETH anyway, thus you don't detect legacy network drivers this way. > >=20 > > Right, but does your platform enable NETDEVICES? It sounds like it > > shouldn't be since you don't have devices in U-Boot? Or something else? > >=20 >=20 > NETDEVICES is off, obviously. Right, so, this patch should make the EFI code test for NETDEVICES and not NET, and then you wouldn't need to hack in something on your platform I think. --=20 Tom --z5HJNHpVrs9F5Roc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJgoIACgkQFHw5/5Y0 tyy4Jwv9GJQlRM/25j+5TLOCbH0sRYMP6uaKxQTLICh2R03gM3o/3cUkPYNd+La/ LfhBJyWoJSp4FHRfQ52eLj+VMrEfPRP6qL0kaFHvhX9Q7YZeYFqgdmAsOXz0KMBI +Q9SEjCu6HT747h/QIbj+HDbFxdwYTs8TLV5Kixxh2jF4GciEWhKH3TAjkEzpF8n 82C2dKi3rhxOojCwQ4reLWiIbITL45gBDqQSq5J31CJ6w9+treQMdTyYqDutK8/v J81N0yHaiRzoYLSk3Mkr7y6zzl/jS9/LXSbzJgYILm1LlOf7fF/htRjUcqiWktpp l8TPIetVNyccL0WWMc0LKrNi4y7/K8QH2b8xuuLlw19TGOva2CKp7dEn6KfWO0Nh BHfM+OMSJ9fIUA/T8M5Eafa25VYKJ7DqlF0em4vjv2GHQ/g0PSU2oWlmTQhyj4U3 IPnRIW7tP3w7pHD05AZGhifOxXpe4eR4oI8OhaRcAHCU0jR+SM2+kXjoHukz77bQ Y+WiX0bG =KTwd -----END PGP SIGNATURE----- --z5HJNHpVrs9F5Roc--