From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF3BBC4332F for ; Fri, 14 Oct 2022 16:01:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3F65284F84; Fri, 14 Oct 2022 17:59:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qYM6bUHr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1071284F79; Fri, 14 Oct 2022 17:59:00 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8FC6A84F69 for ; Fri, 14 Oct 2022 17:58:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id f14so3506249qvo.3 for ; Fri, 14 Oct 2022 08:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IzuwOg+Q5RBJEjVv1geZtnFj2Vu5Yit3kzbluNYvFU8=; b=qYM6bUHrDvkzVTclu5AXGu6YNCqQ+zS6I+Zw1iFB1jkZHYr0QFIwPJwaEbn+oPinBd I7GRFfr63PwcKpzLw6X59jnYeCfieXcE/ZMTd+M2kJJqlPifMO2Z0JUPHZ3lVvX/6LM9 2ws1DLGksQQg02m1NsBqjNEA9q/FwyFBel7DY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IzuwOg+Q5RBJEjVv1geZtnFj2Vu5Yit3kzbluNYvFU8=; b=LrEnaYmEH800nKirCBPfJVX+YtuEuOMEoPuy0M7S/xQ5s9/7V3rBeEdvh6Ku9FtVX3 mzBQyGRz+/eQMupb7/+HOyV05/4Qz1jgAJ8f39XxU8QOlzbG1+HcDzbkt4FaKaHsN8/2 J8VXaUaRdsf2EW4Rit//cbdMEyGQ93f+OjHABgSrlOSRbS4orPS79SLm+NlE+v8lvbZO vlkH5iw53djfnakVHIvysnDuF69pzUssCdU9ywpFwf5mI0wRiFJWOAU8pku3cLl0Y4/x GDXX8lsxSe48mYcaKmMhniY0C0uo6bsa8TeVBnFSU2Tbdh1uMe1vBYjMFA2ElgU7DuRO 3pAQ== X-Gm-Message-State: ACrzQf37J9jm7O5DqXxp3TeSDp2SPqhFkGpHY6Fh77UVGQiyLE0hkBO0 6ClrOQ2RkjkRwphMS8cSXsGYpQ== X-Google-Smtp-Source: AMsMyM7dIO8P2euQYc3QgzVlu3L8XR5YC+z+2r12hSoyDUiACF88qYevMeVBTgRbEDt5NEI3mJnACQ== X-Received: by 2002:a05:6214:e6b:b0:4b3:dcaf:c3a7 with SMTP id jz11-20020a0562140e6b00b004b3dcafc3a7mr4741717qvb.34.1665763132267; Fri, 14 Oct 2022 08:58:52 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b049-0e25-0576-9c40.res6.spectrum.com. [2603:6081:7b00:6400:b049:e25:576:9c40]) by smtp.gmail.com with ESMTPSA id h16-20020a37de10000000b006a6ebde4799sm2450925qkj.90.2022.10.14.08.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 08:58:51 -0700 (PDT) Date: Fri, 14 Oct 2022 11:58:49 -0400 From: Tom Rini To: Jan Kiszka Cc: Simon Glass , Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Message-ID: <20221014155849.GX2020586@bill-the-cat> References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014131315.GM2020586@bill-the-cat> <20221014153948.GW2020586@bill-the-cat> <1f5dddfc-1345-ad50-53b7-ef53da774f3b@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VJvbhUb+lmZn6RCr" Content-Disposition: inline In-Reply-To: <1f5dddfc-1345-ad50-53b7-ef53da774f3b@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --VJvbhUb+lmZn6RCr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 14, 2022 at 05:47:55PM +0200, Jan Kiszka wrote: > On 14.10.22 17:39, Tom Rini wrote: > > On Fri, Oct 14, 2022 at 09:36:46AM -0600, Simon Glass wrote: > >> Hi Jan, > >> > >> On Fri, 14 Oct 2022 at 09:35, Jan Kiszka wrot= e: > >>> > >>> On 14.10.22 17:33, Simon Glass wrote: > >>>> Hi Tom, > >>>> > >>>> On Fri, 14 Oct 2022 at 07:13, Tom Rini wrote: > >>>>> > >>>>> On Fri, Oct 14, 2022 at 01:51:54PM +0200, Jan Kiszka wrote: > >>>>>> On 21.10.21 01:34, Heinrich Schuchardt wrote: > >>>>>>> On 9/25/21 2:30 AM, Simon Glass wrote: > >>>>>>>> This code should never have been added as it builds a new featur= e on top > >>>>>>>> of legacy code. This has already been improved with the dependen= cy on > >>>>>>>> BLK. > >>>>>>>> > >>>>>>>> Add a dependency on DM_ETH also, to avoid needing to deal with t= his old > >>>>>>>> code. > >>>>>>>> > >>>>>>>> Boards which want EFI_LOADER should migrate to driver model firs= t. > >>>>>>>> > >>>>>>>> Note this patch is included to resolve the following build error: > >>>>>>>> > >>>>>>>> lib/efi_loader/efi_runtime.c:680:16: error: =E2=80=98CONFIG_SYS_= TEXT_BASE=E2=80=99 > >>>>>>>> undeclared (first use in this function); did you mean > >>>>>>>> =E2=80=98CONFIG_SYS_SRAM_BASE=E2=80=99? > >>>>>>>> 680 | ulong base =3D CONFIG_SYS_TEXT_BASE; > >>>>>>>> | ^~~~~~~~~~~~~~~~~~~~ > >>>>>>>> | CONFIG_SYS_SRAM_BASE > >>>>>>>> > >>>>>>>> Signed-off-by: Simon Glass > >>>>>>> > >>>>>>> Reviewed-by: Heinrich Schuchardt > >>>>>>> > >>>>>> > >>>>>> How to deal with boards that need CONFIG_NET but do not actually > >>>>>> implement any driver (yet)? This now broke UEFI for the IOT2050 wh= ich > >>>>>> needs NET for network-related device tree setup (see also [1]) and > >>>>>> enforces a local hack for us. > >>>>> > >>>>> Yes, looking at the patch, this should probably use NETDEVICES and = not > >>>>> NET as the test? Would that fix your problem, Jan? > >>>> > >>>> But that selects DM_ETH. You can still enable DM_ETH when there are = no > >>>> devices, so I'm not sure what the problem is. Can you post an error? > >>>> > >>>> Things should be migrated to DM_ETH by now (end of 2020). > >>>> > >>> > >>> I am enable DM_ETH now at board-level, just to make EFI_LOADER happy, > >>> but that feels wrong. > >> > >> I agree, but I wonder if this might need some code refactoring. > >> Perhaps EFI_LOADER_NET needs to be created, net functionality can be > >> disabled? > >=20 > > I think we should be able to leverage existing flags already for this > > and not need a new one. The issue is that CONFIG_NET does not mean "we > > have network devices" but CONFIG_NETDEVICES does. >=20 > So, you mean fixing up the efi-loader code to use CONFIG_NETDEVICES, > rather than CONFIG_NET? Then we could drop that Kconfig check. Yes. --=20 Tom --VJvbhUb+lmZn6RCr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNJhzIACgkQFHw5/5Y0 tyzIqQv+M2PE2N+a4sRA/aOqFDWh4ei7wractdGIxoSp062LuVeTqvtZbw2kgcD5 CaMakbKqvB1pnWtlUR7iWNkI5HdhgvG0iivWGtWsVKMgfoCe1Ax3JzBcfJo28WUp wVa6k3luVQZHoztdJ0UlGZYWhY+9LpTeIBAwd4gnAtQ+63yfRH2D8SYNjCHuMJED kt3/6lFm0gd/y5sZrHXFvRD3dSC/WF8kmolEhi7LdhRuw0MixChFqRSIfI8+Efv9 /+C0+tHYjmtBgdaNpf8mZ1qarTTU9grfAqiCbQyWpXYfSC73L4uZBwmgk/a28zVA dJTZjs7dTQqK15xdQbGqn/DC3E5lioNZe2kwFpBbbkcrEqA98aF0C3DlEgE/WQ+A 1YBTGxdYv2UTckogiCREvUXv7YMAMZsDhF7GoKWns76LOuRkrRuy8UT6TTxtmQOH YOP6uMmDuv/J9C9saWo3r72V8/HS2u+YMiJgSK6DGG2RVxKGK6rl36wRVLzBIl/l AfeLHLN3 =Msat -----END PGP SIGNATURE----- --VJvbhUb+lmZn6RCr--