From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3F4C43217 for ; Fri, 14 Oct 2022 15:37:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbiJNPhm convert rfc822-to-8bit (ORCPT ); Fri, 14 Oct 2022 11:37:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbiJNPhj (ORCPT ); Fri, 14 Oct 2022 11:37:39 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526D816F414; Fri, 14 Oct 2022 08:37:37 -0700 (PDT) Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Mpr6Q34fGz689J2; Fri, 14 Oct 2022 23:34:38 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 17:37:34 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 16:37:34 +0100 Date: Fri, 14 Oct 2022 16:37:33 +0100 From: Jonathan Cameron To: Cosmin Tanislav CC: Nuno =?ISO-8859-1?Q?S=E1?= , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , Rob Herring , "Krzysztof Kozlowski" , , , , Cosmin Tanislav Subject: Re: [PATCH 2/3] dt-bindings: iio: temperature: ltc2983: support more parts Message-ID: <20221014163718.00000042@huawei.com> In-Reply-To: <20221014123724.1401011-3-demonsingur@gmail.com> References: <20221014123724.1401011-1-demonsingur@gmail.com> <20221014123724.1401011-3-demonsingur@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Oct 2022 15:37:23 +0300 Cosmin Tanislav wrote: > From: Cosmin Tanislav > > Add support for the following parts: > * LTC2984 > * LTC2986 > * LTM2985 > > The LTC2984 is a variant of the LTC2983 with EEPROM. > The LTC2986 is a variant of the LTC2983 with only 10 channels, > EEPROM and support for active analog temperature sensors. If they 'work' but with fewer features, perhaps a fallback compatible? > The LTM2985 is software-compatible with the LTC2986. Fallback compatible? > > Signed-off-by: Cosmin Tanislav > --- > .../bindings/iio/temperature/adi,ltc2983.yaml | 63 +++++++++++++++++-- > 1 file changed, 59 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > index 722781aa4697..c33ab524fb64 100644 > --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > +++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml > @@ -4,19 +4,27 @@ > $id: http://devicetree.org/schemas/iio/temperature/adi,ltc2983.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Analog Devices LTC2983 Multi-sensor Temperature system > +title: Analog Devices LTC2983, LTC2986, LTM2985 Multi-sensor Temperature system > > maintainers: > - Nuno Sá > > description: | > - Analog Devices LTC2983 Multi-Sensor Digital Temperature Measurement System > + Analog Devices LTC2983, LTC2984, LTC2986, LTM2985 Multi-Sensor Digital > + Temperature Measurement Systems > + > https://www.analog.com/media/en/technical-documentation/data-sheets/2983fc.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/2984fb.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/29861fa.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/ltm2985.pdf > > properties: > compatible: > enum: > - adi,ltc2983 > + - adi,ltc2984 > + - adi,ltc2986 > + - adi,ltm2985 > > reg: > maxItems: 1 > @@ -26,7 +34,7 @@ properties: > > adi,mux-delay-config-us: > description: > - The LTC2983 performs 2 or 3 internal conversion cycles per temperature > + The device performs 2 or 3 internal conversion cycles per temperature Definitely a lesson here in avoiding device names in the descriptions! > result. Each conversion cycle is performed with different excitation and > input multiplexer configurations. Prior to each conversion, these > excitation circuits and input switch configurations are changed and an > @@ -145,7 +153,7 @@ patternProperties: > adi,three-conversion-cycles: > description: > Boolean property which set's three conversion cycles removing > - parasitic resistance effects between the LTC2983 and the diode. > + parasitic resistance effects between the device and the diode. > type: boolean > > adi,average-on: > @@ -353,6 +361,41 @@ patternProperties: > description: Boolean property which set's the adc as single-ended. > type: boolean > > + "^temp@": > + type: object > + description: > + Represents a channel which is being used as an active analog temperature > + sensor. > + > + properties: > + adi,sensor-type: > + description: > + Identifies the sensor as an active analog temperature sensor. > + $ref: /schemas/types.yaml#/definitions/uint32 > + const: 31 Ah. This is a bit odd as it's fixed for the channel type. However there is precedence in this binding so fair enough. > + > + adi,single-ended: > + description: Boolean property which sets the sensor as single-ended. > + type: boolean > + > + adi,custom-temp: > + description: > + This is a table, where each entry should be a pair of > + voltage(mv)-temperature(K). The entries must be given in nv and uK > + so that, the original values must be multiplied by 1000000. For > + more details look at table 71 and 72. > + Note should be signed, but dtc doesn't currently maintain the > + sign. > + $ref: /schemas/types.yaml#/definitions/uint64-matrix > + minItems: 3 > + maxItems: 64 > + items: > + minItems: 2 > + maxItems: 2 > + > + required: > + - adi,custom-temp > + > "^rsense@": > type: object > description: > @@ -382,6 +425,18 @@ required: > - reg > - interrupts > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - adi,ltc2983 > + - adi,ltc2984 > + then: > + patternProperties: > + "^temp@": false > + > additionalProperties: false > > examples: