All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: "Bernd Kuhls" <bernd.kuhls@t-online.de>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"William Wennerström" <william@willeponken.me>,
	"TIAN Yuanhao" <tianyuanhao3@163.com>,
	"Heiko Thiery" <heiko.thiery@gmail.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Subject: [Buildroot] [PATCH] rtl8188eu: remove package
Date: Mon, 17 Oct 2022 09:39:53 +0200	[thread overview]
Message-ID: <20221017073953.510219-1-luca.ceresoli@bootlin.com> (raw)

From: Luca Ceresoli <luca.ceresoli@bootlin.com>

This package fails building with a kernel >= 6.0 [0] due to internal API
changes [1]:

  .../ioctl_cfg80211.c: In function ‘rtw_cfg80211_indicate_connect’:
  ...ioctl_cfg80211.c:709:12: error: ‘struct cfg80211_roam_info’ has no member named ‘channel’
  709 |   roam_info.channel = notify_channel;
      |            ^
  ...ioctl_cfg80211.c:710:12: error: ‘struct cfg80211_roam_info’ has no member named ‘bssid’
  710 |   roam_info.bssid = cur_network->network.MacAddress;
      |            ^

There is currently no fix in the github repository, and it's probably not
worth fixing because, as the Config.in help text states:

  This is needed only for Linux kernels before 3.12.
  Since 3.12, there is a (staging) driver in mainline, with a
  similar codebase.

Kernel 3.12 is 9 years old now, and the oldest kernel currently supported
is 4.9.

[0] http://autobuild.buildroot.org/results/550/550640296a92826f6f04d2344adde75c3025ea35/
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/include/net/cfg80211.h?id=efbabc11650040c64884ff3019b88c7bcc0ceb1d

Cc: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Petr Vorel <petr.vorel@gmail.com>
Cc: Peter Seiderer <ps.report@gmx.net>
Cc: Heiko Thiery <heiko.thiery@gmail.com>
Cc: William Wennerström <william@willeponken.me>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 DEVELOPERS                       |  1 -
 package/Config.in                |  1 -
 package/rtl8188eu/Config.in      | 21 ---------------------
 package/rtl8188eu/rtl8188eu.hash |  3 ---
 package/rtl8188eu/rtl8188eu.mk   | 28 ----------------------------
 5 files changed, 54 deletions(-)
 delete mode 100644 package/rtl8188eu/Config.in
 delete mode 100644 package/rtl8188eu/rtl8188eu.hash
 delete mode 100644 package/rtl8188eu/rtl8188eu.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index c0e6f8bbef3d..b1e84edd5e9a 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1810,7 +1810,6 @@ F:	package/agentpp/
 F:	package/exim/
 F:	package/libpjsip/
 F:	package/qpid-proton/
-F:	package/rtl8188eu/
 F:	package/snmppp/
 F:	package/stm32flash/
 F:	package/unzip/
diff --git a/package/Config.in b/package/Config.in
index e3a34d6e97d3..d95a6ac4e3fb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -573,7 +573,6 @@ endmenu
 	source "package/rpi-userland/Config.in"
 	source "package/rs485conf/Config.in"
 	source "package/rtc-tools/Config.in"
-	source "package/rtl8188eu/Config.in"
 	source "package/rtl8189es/Config.in"
 	source "package/rtl8189fs/Config.in"
 	source "package/rtl8723bu/Config.in"
diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in
deleted file mode 100644
index 76d90852976a..000000000000
--- a/package/rtl8188eu/Config.in
+++ /dev/null
@@ -1,21 +0,0 @@
-config BR2_PACKAGE_RTL8188EU
-	bool "rtl8188eu"
-	depends on !BR2_s390x
-	depends on BR2_LINUX_KERNEL
-	help
-	  A standalone driver for the RTL8188EU USB Wi-Fi adapter.
-	  This is needed only for Linux kernels before 3.12.
-	  Since 3.12, there is a (staging) driver in mainline, with a
-	  similar codebase.
-
-	  Make sure your target kernel has the CONFIG_WIRELESS_EXT
-	  config option enabled.
-
-	  Note: this package needs a firmware loading mechanism to load
-	  the binary blob for the chip to work.
-
-	  https://github.com/lwfinger/rtl8188eu
-
-comment "rtl8188eu needs a Linux kernel to be built"
-	depends on !BR2_s390x
-	depends on !BR2_LINUX_KERNEL
diff --git a/package/rtl8188eu/rtl8188eu.hash b/package/rtl8188eu/rtl8188eu.hash
deleted file mode 100644
index 9c7f2de4b61e..000000000000
--- a/package/rtl8188eu/rtl8188eu.hash
+++ /dev/null
@@ -1,3 +0,0 @@
-# Locally computed
-sha256  6bc46a13b20a2ed121844e51fd690216b2ab3b1faa1af8d9501090026ca9bd22  rtl8188eu-903b6fcb821465fe9c63e83416080df70c1c3c90.tar.gz
-sha256  af8067302947c01fd9eee72befa54c7e3ef8a48fecde7fd71277f2290b2bf0f7  COPYING
diff --git a/package/rtl8188eu/rtl8188eu.mk b/package/rtl8188eu/rtl8188eu.mk
deleted file mode 100644
index ebce4617ac5c..000000000000
--- a/package/rtl8188eu/rtl8188eu.mk
+++ /dev/null
@@ -1,28 +0,0 @@
-################################################################################
-#
-# rtl8188eu
-#
-################################################################################
-
-RTL8188EU_VERSION = 903b6fcb821465fe9c63e83416080df70c1c3c90
-RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION))
-RTL8188EU_LICENSE = GPL-2.0, proprietary (rtl8188eufw.bin firmware blob)
-RTL8188EU_LICENSE_FILES = COPYING
-RTL8188EU_MODULE_MAKE_OPTS = CONFIG_RTL8188EU=m
-
-define RTL8188EU_LINUX_CONFIG_FIXUPS
-	$(call KCONFIG_ENABLE_OPT,CONFIG_NET)
-	$(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
-	$(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
-	$(call KCONFIG_ENABLE_OPT,CONFIG_USB_SUPPORT)
-	$(call KCONFIG_ENABLE_OPT,CONFIG_USB)
-endef
-
-define RTL8188EU_INSTALL_FIRMWARE
-	$(INSTALL) -D -m 644 $(@D)/rtl8188eufw.bin \
-		$(TARGET_DIR)/lib/firmware/rtlwifi/rtl8188eufw.bin
-endef
-RTL8188EU_POST_INSTALL_TARGET_HOOKS += RTL8188EU_INSTALL_FIRMWARE
-
-$(eval $(kernel-module))
-$(eval $(generic-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2022-10-17  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  7:39 Luca Ceresoli via buildroot [this message]
2022-10-17 19:10 ` [Buildroot] [PATCH] rtl8188eu: remove package Peter Seiderer
2022-10-17 20:19   ` Giulio Benetti
2022-10-17 22:21   ` Petr Vorel
2022-10-17 22:34     ` Petr Vorel
2022-10-18  6:59   ` Luca Ceresoli via buildroot
2022-10-18 13:15     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017073953.510219-1-luca.ceresoli@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=bernd.kuhls@t-online.de \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=heiko.thiery@gmail.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=ps.report@gmx.net \
    --cc=tianyuanhao3@163.com \
    --cc=william@willeponken.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.