Re: [PATCH V6 3/8] libgpiod: Add rust wrapper crate

From: Viresh Kumar <viresh.kumar@linaro.org>
To: Kent Gibson <warthog618@gmail.com>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Vincent Guittot" <vincent.guittot@linaro.org>,
	linux-gpio@vger.kernel.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	stratos-dev@op-lists.linaro.org,
	"Gerard Ryan" <g.m0n3y.2503@gmail.com>
Subject: Re: [PATCH V6 3/8] libgpiod: Add rust wrapper crate
Date: Mon, 17 Oct 2022 17:07:49 +0530	[thread overview]
Message-ID: <20221017113749.zqvs6ul2qj4rddue@vireshk-i7> (raw)
In-Reply-To: <Y009rqtA1h00ZVN5@sol>

On 17-10-22, 19:34, Kent Gibson wrote:
> > +    pub fn set_prop(&mut self, props: &[SettingVal]) -> Result<()> {
>                                                                   ^   
>                                                         also &mut Self
> 
> Apart from that, yeah that is what I had in mind, as also noted in my
> forthcoming v7 review.

Ahh yes.

diff --git a/bindings/rust/libgpiod/src/line_settings.rs b/bindings/rust/libgpiod/src/line_settings.rs
index be50b5b41c5a..92e8928517f7 100644
--- a/bindings/rust/libgpiod/src/line_settings.rs
+++ b/bindings/rust/libgpiod/src/line_settings.rs
@@ -70,7 +70,7 @@ impl Settings {
     }

     /// Set line prop setting.
-    pub fn set_prop(&mut self, props: &[SettingVal]) -> Result<()> {
+    pub fn set_prop(&mut self, props: &[SettingVal]) -> Result<&mut Self> {
         for property in props {
             match property {
                 SettingVal::Direction(prop) => self.set_direction(*prop)?,
@@ -84,7 +84,7 @@ impl Settings {
             };
         }

-        Ok(())
+        Ok(self)
     }

     /// Get the line prop setting.

-- 
viresh
