From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7901BC433FE for ; Mon, 17 Oct 2022 12:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230338AbiJQMtA (ORCPT ); Mon, 17 Oct 2022 08:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbiJQMs5 (ORCPT ); Mon, 17 Oct 2022 08:48:57 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF735C97E; Mon, 17 Oct 2022 05:48:49 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 5E1EE1C0023; Mon, 17 Oct 2022 14:48:47 +0200 (CEST) Date: Mon, 17 Oct 2022 14:48:46 +0200 From: Pavel Machek To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Harry Stern , Benjamin Tissoires , jikos@kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.9 03/10] hid: topre: Add driver fixing report descriptor Message-ID: <20221017124846.GB13227@duo.ucw.cz> References: <20221013002802.1896096-1-sashal@kernel.org> <20221013002802.1896096-3-sashal@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="24zk1gE8NUlDmwG9" Content-Disposition: inline In-Reply-To: <20221013002802.1896096-3-sashal@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --24zk1gE8NUlDmwG9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Harry Stern >=20 > [ Upstream commit a109d5c45b3d6728b9430716b915afbe16eef27c ] >=20 > The Topre REALFORCE R2 firmware incorrectly reports that interface > descriptor number 1, input report descriptor 2's events are array events > rather than variable events. That particular report descriptor is used > to report keypresses when there are more than 6 keys held at a time. > This bug prevents events from this interface from being registered > properly, so only 6 keypresses (from a different interface) can be > registered at once, rather than full n-key rollover. >=20 > This commit fixes the bug by setting the correct value in a report_fixup > function. >=20 > The original bug report can be found here: > Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/804 >=20 > Thanks to Benjamin Tissoires for diagnosing the issue with the report > descriptor. Come on, whole new driver to work around hw problem that is not really serious. Plus this won't really do anything unless people enable it in config. This should not be in stable. Best regards, Pavel > Signed-off-by: Harry Stern > Signed-off-by: Benjamin Tissoires > Link: https://lore.kernel.org/r/20220911003614.297613-1-harry@harrystern.= net > Signed-off-by: Sasha Levin > --- > drivers/hid/Kconfig | 6 +++++ > drivers/hid/Makefile | 1 + > drivers/hid/hid-ids.h | 3 +++ > drivers/hid/hid-topre.c | 49 +++++++++++++++++++++++++++++++++++++++++ --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --24zk1gE8NUlDmwG9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY01PLgAKCRAw5/Bqldv6 8kdsAJ9lvQoxJ3ffIjkIWlnFNChhUI+/iQCfVZLCVxHpaAXYQsfAQV6JKd5A8yw= =YMaE -----END PGP SIGNATURE----- --24zk1gE8NUlDmwG9--