From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A54C433FE for ; Tue, 18 Oct 2022 00:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231904AbiJRAQC (ORCPT ); Mon, 17 Oct 2022 20:16:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231767AbiJRAOR (ORCPT ); Mon, 17 Oct 2022 20:14:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06FAF89AD5; Mon, 17 Oct 2022 17:11:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C9BDB81C09; Tue, 18 Oct 2022 00:10:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4DFFC433D6; Tue, 18 Oct 2022 00:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666051858; bh=7HNBvrlCdNfUOqpSlMUmdLVZsAZsrkyGhhakEty46g4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XI83f8IombOZm8gl7mu2f2u3Y/Wu2i7tRSeOFW6bgRtIUqwf3cxFBUhLwSOouaNsc Bh3PwnF/ReRpFyrOu3IIWNMOlzPzum+GaoA+BPCyUK4RE1xCI6uWDBVoAidIMTOFQH pp9n6W0Q/Vd2usBiVdW0nv3II9WgXorZArbSEkbDILHL+faG0pcLp0LZeHSzCKur6y VXDDFBbFUK5XDdMco/aCt47LqY4EtFKex2Ck0uz1xMAAGbNwOorAAzFsGgi/aYyd2h xS3accijAjS1okn69icRCOmPISeOIYRGdd6WNZtq8MiaZY3ZwvSstZRzOQlazdMBZx 9DWyDs7jXzZ8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dominique Martinet , syzbot+50f7e8d06c3768dd97f3@syzkaller.appspotmail.com, Schspa Shi , Sasha Levin , ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 14/16] 9p: trans_fd/p9_conn_cancel: drop client lock earlier Date: Mon, 17 Oct 2022 20:10:27 -0400 Message-Id: <20221018001029.2731620-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221018001029.2731620-1-sashal@kernel.org> References: <20221018001029.2731620-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dominique Martinet [ Upstream commit 52f1c45dde9136f964d63a77d19826c8a74e2c7f ] syzbot reported a double-lock here and we no longer need this lock after requests have been moved off to local list: just drop the lock earlier. Link: https://lkml.kernel.org/r/20220904064028.1305220-1-asmadeus@codewreck.org Reported-by: syzbot+50f7e8d06c3768dd97f3@syzkaller.appspotmail.com Signed-off-by: Dominique Martinet Tested-by: Schspa Shi Signed-off-by: Sasha Levin --- net/9p/trans_fd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 8f528e783a6c..c4096b14d159 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -205,6 +205,8 @@ static void p9_conn_cancel(struct p9_conn *m, int err) list_move(&req->req_list, &cancel_list); } + spin_unlock(&m->client->lock); + list_for_each_entry_safe(req, rtmp, &cancel_list, req_list) { p9_debug(P9_DEBUG_ERROR, "call back req %p\n", req); list_del(&req->req_list); @@ -212,7 +214,6 @@ static void p9_conn_cancel(struct p9_conn *m, int err) req->t_err = err; p9_client_cb(m->client, req, REQ_STATUS_ERROR); } - spin_unlock(&m->client->lock); } static __poll_t -- 2.35.1