From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>
Cc: kvm@vger.kernel.org, frankja@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 0/1] s390x: do not enable PV dump support by default
Date: Wed, 19 Oct 2022 17:19:43 +0200 [thread overview]
Message-ID: <20221019171920.455451ea@p-imbrenda> (raw)
In-Reply-To: <20221019145320.1228710-1-nrb@linux.ibm.com>
On Wed, 19 Oct 2022 16:53:19 +0200
Nico Boehr <nrb@linux.ibm.com> wrote:
> v1->v2:
> ---
> * add indent to CONFIG_DUMP if in Makefile (thanks Janosch)
> * add comment (thanks Janosch)
>
> Currently, dump support is always enabled by setting the respective
> plaintext control flag (PCF). Unfortunately, older machines without
> support for PV dump will not start the guest when this PCF is set.
maybe for the long term we could try to fix the stub generated by
genprotimg to check the plaintext flags and the available features and
refuse to try to start if the required features are missing.
ideally providing a custom message when generating the image, to be
shown if the required features are missing. e.g. for kvm unit test, the
custom message could be something like
SKIP: $TEST_NAME: Missing hardware features
once that is in place, we could revert this patch
>
> Nico Boehr (1):
> s390x: do not enable PV dump support by default
>
> configure | 11 +++++++++++
> s390x/Makefile | 26 +++++++++++++++++---------
> 2 files changed, 28 insertions(+), 9 deletions(-)
>
next prev parent reply other threads:[~2022-10-19 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:53 [kvm-unit-tests PATCH v2 0/1] s390x: do not enable PV dump support by default Nico Boehr
2022-10-19 14:53 ` [kvm-unit-tests PATCH v2 1/1] " Nico Boehr
2022-10-19 15:13 ` Claudio Imbrenda
2022-10-20 6:56 ` Janosch Frank
2022-10-19 15:19 ` Claudio Imbrenda [this message]
2022-10-19 15:24 ` [kvm-unit-tests PATCH v2 0/1] " Nico Boehr
2022-10-19 16:03 ` Claudio Imbrenda
2022-10-19 15:47 ` Janosch Frank
2022-10-19 16:17 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019171920.455451ea@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.