All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Josef Bacik <josef@toxicpanda.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 02/15] btrfs: move assert helpers out of ctree.h
Date: Thu, 20 Oct 2022 17:52:47 +0200	[thread overview]
Message-ID: <20221020155247.GK13389@twin.jikos.cz> (raw)
In-Reply-To: <20221020154957.GJ13389@twin.jikos.cz>

On Thu, Oct 20, 2022 at 05:49:57PM +0200, David Sterba wrote:
> On Wed, Oct 19, 2022 at 10:50:48AM -0400, Josef Bacik wrote:
> > These call functions that aren't defined in, or will be moved out of,
> > ctree.h  Move them to super.c where the other assert/error message code
> > is defined.
> > 
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> > ---
> >  fs/btrfs/ctree.h | 18 +++---------------
> >  fs/btrfs/super.c | 14 ++++++++++++++
> >  2 files changed, 17 insertions(+), 15 deletions(-)
> > 
> > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> > index 52987ee61c72..c97a02a81517 100644
> > --- a/fs/btrfs/ctree.h
> > +++ b/fs/btrfs/ctree.h
> > @@ -3320,18 +3320,11 @@ do {								\
> >  } while (0)
> >  
> >  #ifdef CONFIG_BTRFS_ASSERT
> > -__cold __noreturn
> 
> I think __noreturn should be preserved as BUG() is called in the new
> function too

But objtool for some reason does not like it, tons of warnings like

fs/btrfs/dir-item.o: warning: objtool: .text.unlikely: unexpected end of section
fs/btrfs/xattr.o: warning: objtool: btrfs_setxattr() falls through to next function btrfs_setxattr_trans.cold()
fs/btrfs/xattr.o: warning: objtool: .text.unlikely: unexpected end of section

so I'll drop the attribute.

  reply	other threads:[~2022-10-20 15:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19 14:50 [PATCH v3 00/15] btrfs: split out larger chunks of ctree.h Josef Bacik
2022-10-19 14:50 ` [PATCH v3 01/15] btrfs: move fs wide helpers out " Josef Bacik
2022-10-20  6:08   ` Johannes Thumshirn
2022-10-21  6:11   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 02/15] btrfs: move assert " Josef Bacik
2022-10-20  6:09   ` Johannes Thumshirn
2022-10-20 15:49   ` David Sterba
2022-10-20 15:52     ` David Sterba [this message]
2022-10-19 14:50 ` [PATCH v3 03/15] btrfs: move the printk " Josef Bacik
2022-10-20  6:16   ` Johannes Thumshirn
2022-10-19 14:50 ` [PATCH v3 04/15] btrfs: push printk index code into their respective helpers Josef Bacik
2022-10-19 14:50 ` [PATCH v3 05/15] btrfs: move BTRFS_FS_STATE* defs and helpers to fs.h Josef Bacik
2022-10-19 14:50 ` [PATCH v3 06/15] btrfs: convert incompat and compat flag test helpers to defines Josef Bacik
2022-10-19 14:50 ` [PATCH v3 07/15] btrfs: move mount option definitions to fs.h Josef Bacik
2022-10-21  7:13   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 08/15] btrfs: move fs_info->flags enum " Josef Bacik
2022-10-21  6:57   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 09/15] btrfs: add a BTRFS_FS_NEED_TRANS_COMMIT flag Josef Bacik
2022-10-21  6:03   ` Anand Jain
2022-10-21  7:14     ` David Sterba
2022-10-19 14:50 ` [PATCH v3 10/15] btrfs: remove fs_info::pending_changes and related code Josef Bacik
2022-10-21  7:24   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 11/15] btrfs: move the compat/incompat flag masks to fs.h Josef Bacik
2022-10-21  7:16   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 12/15] btrfs: rename struct-funcs.c -> accessors.c Josef Bacik
2022-10-21  7:29   ` Anand Jain
2022-10-19 14:50 ` [PATCH v3 13/15] btrfs: move btrfs_map_token to accessors Josef Bacik
2022-10-20  6:22   ` Johannes Thumshirn
2022-10-19 14:51 ` [PATCH v3 14/15] btrfs: move accessor helpers into accessors.h Josef Bacik
2022-10-19 14:51 ` [PATCH v3 15/15] btrfs: remove temporary btrfs_map_token declaration in ctree.h Josef Bacik
2022-10-20  6:23   ` Johannes Thumshirn
2022-10-21  7:25   ` Anand Jain
2022-10-20 16:29 ` [PATCH v3 00/15] btrfs: split out larger chunks of ctree.h David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020155247.GK13389@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.