All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>
Subject: [PATCH 08/16] ASoC: SOF: Intel: hda-dai: remove useless members in hda_pipe_params
Date: Mon, 24 Oct 2022 11:53:02 -0500	[thread overview]
Message-ID: <20221024165310.246183-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20221024165310.246183-1-pierre-louis.bossart@linux.intel.com>

Some settings were never or are no longer used, remove useless
definitions and assignments.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/sof/intel/hda-dai.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/sound/soc/sof/intel/hda-dai.c b/sound/soc/sof/intel/hda-dai.c
index 2bce8dff4627a..6e368974abd16 100644
--- a/sound/soc/sof/intel/hda-dai.c
+++ b/sound/soc/sof/intel/hda-dai.c
@@ -32,11 +32,8 @@ MODULE_PARM_DESC(sof_use_tplg_nhlt, "SOF topology nhlt override");
 struct hda_pipe_params {
 	u32 ch;
 	u32 s_freq;
-	u32 s_fmt;
-	u8 linktype;
 	snd_pcm_format_t format;
 	int link_index;
-	int stream;
 	unsigned int link_bps;
 };
 
@@ -235,10 +232,8 @@ static int hda_link_dma_hw_params(struct snd_pcm_substream *substream,
 	/* set the hdac_stream in the codec dai */
 	snd_soc_dai_set_stream(codec_dai, hdac_stream(hext_stream), substream->stream);
 
-	p_params.s_fmt = snd_pcm_format_width(params_format(params));
 	p_params.ch = params_channels(params);
 	p_params.s_freq = params_rate(params);
-	p_params.stream = substream->stream;
 	p_params.link_index = hlink->index;
 	p_params.format = params_format(params);
 
-- 
2.34.1


  parent reply	other threads:[~2022-10-24 16:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 16:52 [PATCH 00/16] ASoC: SOF: Intel: HDaudio cleanups Pierre-Louis Bossart
2022-10-24 16:52 ` [PATCH 01/16] ASoC: SOF: ops: fallback to mmio in helpers Pierre-Louis Bossart
2022-10-24 16:52 ` [PATCH 02/16] ASoC: SOF: Intel: use mmio fallback for all platforms Pierre-Louis Bossart
2022-10-24 16:52 ` [PATCH 03/16] ASoC: SOF: ops: add readb/writeb helpers Pierre-Louis Bossart
2022-10-27 18:51   ` Nathan Chancellor
2022-10-27 19:58     ` Pierre-Louis Bossart
2022-10-27 20:02       ` Nathan Chancellor
2022-10-24 16:52 ` [PATCH 04/16] ASoC: SOF: ops: add snd_sof_dsp_updateb() helper Pierre-Louis Bossart
2022-10-24 16:52 ` [PATCH 05/16] ASoC: SOF: Intel: hda-dsp: use SOF helpers for consistency Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 06/16] ASoC: SOF: Intel: hda-dai: start removing the use of runtime->private_data in BE Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 07/16] ASoC: SOF: Intel: hda-dai: use component_get_drvdata to find hdac_bus Pierre-Louis Bossart
2022-10-24 16:53 ` Pierre-Louis Bossart [this message]
2022-10-24 16:53 ` [PATCH 09/16] ASoC: SOF: Intel: hda-ctrl: remove useless sleep Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 10/16] ASoC: SOF: Intel: hda: always do a full reset Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 11/16] ASoC: SOF: Intel: hda: remove useless check on GCTL Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 12/16] ASoC: SOF: Intel: hda-stream: use SOF helpers for consistency Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 13/16] ASoC: SOF: Intel: hda-stream: rename CL_SD_CTL registers as SD_CTL Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 14/16] ASoC: SOF: Intel: hda: use SOF helper for consistency Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 15/16] ASoC: SOF: Intel: hda-stream: use snd_sof_dsp_updateb() helper Pierre-Louis Bossart
2022-10-24 16:53 ` [PATCH 16/16] ASoC: SOF: Intel: hda-stream: use readb/writeb for stream registers Pierre-Louis Bossart
2022-10-26 19:04 ` [PATCH 00/16] ASoC: SOF: Intel: HDaudio cleanups Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024165310.246183-9-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.