From: Christian Brauner <brauner@kernel.org>
To: Dawei Li <set_pte_at@outlook.com>
Cc: viro@zeniv.linux.org.uk, neilb@suse.de,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: Make vfs_get_super() internal
Date: Tue, 25 Oct 2022 16:36:07 +0200 [thread overview]
Message-ID: <20221025143607.frmf3qg7j4kwezll@wittgenstein> (raw)
In-Reply-To: <TYCP286MB2323D37F4F6400FD07D7C7F7CA319@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Tue, Oct 25, 2022 at 10:24:01PM +0800, Dawei Li wrote:
> For now there are no external callers of vfs_get_super(),
> so just make it an internal API.
>
> base-commit: 3aca47127a646165965ff52803e2b269eed91afc
>
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>
> ---
> fs/super.c | 3 +--
> include/linux/fs_context.h | 4 ----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/fs/super.c b/fs/super.c
> index 6a82660e1adb..cde412f900c7 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1136,7 +1136,7 @@ static int test_single_super(struct super_block *s, struct fs_context *fc)
> * A permissions check is made by sget_fc() unless we're getting a superblock
> * for a kernel-internal mount or a submount.
> */
> -int vfs_get_super(struct fs_context *fc,
> +static int vfs_get_super(struct fs_context *fc,
> enum vfs_get_super_keying keying,
> int (*fill_super)(struct super_block *sb,
> struct fs_context *fc))
If you want to make it static that you should probably also make enum
vfs_get_super_keying static by moving it into super.c. It's not used
anywhere but for vfs_get_super() afaict.
next prev parent reply other threads:[~2022-10-25 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 14:24 [PATCH] vfs: Make vfs_get_super() internal Dawei Li
2022-10-25 14:36 ` Christian Brauner [this message]
2022-10-25 14:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025143607.frmf3qg7j4kwezll@wittgenstein \
--to=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=set_pte_at@outlook.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.