Re: [PATCH v2 2/6] can: rcar_canfd: Add max_channels to struct rcar_canfd_hw_info

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

On 26.10.2022 14:17:28, Biju Das wrote:
> R-Car V3U supports a maximum of 8 channels whereas rest of the SoCs
> support 2 channels.
> 
> Add max_channels variable to struct rcar_canfd_hw_info to handle this
> difference.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1->v2:
>  * Replaced data type of max_channels from u32->unsigned int.
>  * Added Rb tag from Geert.
> ---
>  drivers/net/can/rcar/rcar_canfd.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
> index 5660bf0cd755..00e06cd26487 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -525,6 +525,7 @@ struct rcar_canfd_global;
>  
>  struct rcar_canfd_hw_info {
>  	enum rcanfd_chip_id chip_id;
> +	unsigned int max_channels;

You can save some bytes of you make this an u8 and the postdiv in the
next patch, too.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]