From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity
Date: Thu, 27 Oct 2022 00:46:47 -0700 [thread overview]
Message-ID: <20221027074652.1044235-1-dmitry.torokhov@gmail.com> (raw)
When resetting the block, the reset line is being driven low and then
high, which means that the line in DTS should be annotated as "active
low". It will become important when wcd9335 driver will be converted
to gpiod API that respects declared line polarities.
Fixes: f3eb39a55a1f ("arm64: dts: db820c: Add sound card support")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 5ff8de3e3de7..d5271718d03c 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -3354,7 +3354,7 @@ wcd9335: codec@1,0 {
interrupt-names = "intr1", "intr2";
interrupt-controller;
#interrupt-cells = <1>;
- reset-gpios = <&tlmm 64 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
slim-ifc-dev = <&tasha_ifd>;
--
2.38.0.135.g90850a2211-goog
next reply other threads:[~2022-10-27 7:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 7:46 Dmitry Torokhov [this message]
2022-10-27 7:46 ` [PATCH 2/6] ASoC: dt-bindings: wcd9335: fix reset line polarity in example Dmitry Torokhov
2022-10-27 13:44 ` Krzysztof Kozlowski
2022-10-27 7:46 ` [PATCH 3/6] arm64: dts: qcom: sm8250-mtp: fix reset line polarity Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 4/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 3.0/3.1 Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 5/6] arm64: dts: qcom: sc7280: fix codec reset line polarity for CRD 1.0/2.0 Dmitry Torokhov
2022-10-27 7:46 ` [PATCH 6/6] ASoC: dt-bindings: wcd938x: fix codec reset line polarity in example Dmitry Torokhov
2022-10-27 13:44 ` Krzysztof Kozlowski
2022-10-28 19:39 ` Rob Herring
2022-11-07 3:12 ` (subset) [PATCH 1/6] arm64: dts: qcom: msm8996: fix sound card reset line polarity Bjorn Andersson
2022-11-25 21:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027074652.1044235-1-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.