All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org
Subject: Re: [PATCH 8/9] target/s390x: Use Int128 for returning float128
Date: Thu, 27 Oct 2022 13:18:02 +0200	[thread overview]
Message-ID: <20221027111802.t7p2txte5qbdtoyz@heavy> (raw)
In-Reply-To: <20221021073006.2398819-9-richard.henderson@linaro.org>

On Fri, Oct 21, 2022 at 05:30:05PM +1000, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/s390x/helper.h          | 22 +++++++--------
>  target/s390x/tcg/fpu_helper.c  | 29 ++++++++++----------
>  target/s390x/tcg/translate.c   | 49 +++++++++++++++++++---------------
>  target/s390x/tcg/insn-data.def | 20 +++++++-------
>  4 files changed, 63 insertions(+), 57 deletions(-)
> 

> @@ -2032,7 +2031,7 @@ static DisasJumpType op_cxlgb(DisasContext *s, DisasOps *o)
>      if (!m34) {
>          return DISAS_NORETURN;
>      }
> -    gen_helper_cxlgb(o->out, cpu_env, o->in2, m34);
> +    gen_helper_cxlgb(o->out_128, cpu_env, o->in2, m34);
>      tcg_temp_free_i32(m34);
>      return_low128(o->out2);
>      return DISAS_NEXT;

Do we still need return_low128() here?

>  static DisasJumpType op_lxeb(DisasContext *s, DisasOps *o)
>  {
> -    gen_helper_lxeb(o->out, cpu_env, o->in2);
> +    gen_helper_lxeb(o->out_128, cpu_env, o->in2);
>      return_low128(o->out2);
>      return DISAS_NEXT;
>  }

Same question.


  parent reply	other threads:[~2022-10-27 11:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  7:29 [PATCH 0/9] target/s390x: Use Int128 for float128 and retxl Richard Henderson
2022-10-21  7:29 ` [PATCH 1/9] target/s390x: Use a single return for helper_divs32/u32 Richard Henderson
2022-10-21 11:25   ` Ilya Leoshkevich
2022-10-25  9:59   ` Philippe Mathieu-Daudé
2022-11-01 11:09   ` Ilya Leoshkevich
2022-11-01 11:13   ` [PATCH] tests/tcg/s390x: Add div.c Ilya Leoshkevich
2022-10-21  7:29 ` [PATCH 2/9] target/s390x: Use a single return for helper_divs64/u64 Richard Henderson
2022-10-24 13:16   ` Philippe Mathieu-Daudé
2022-10-25 20:47   ` Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 3/9] target/s390x: Use Int128 for return from CLST Richard Henderson
2022-10-24 13:15   ` Philippe Mathieu-Daudé
2022-10-25 21:22   ` Ilya Leoshkevich
2022-10-25 21:30   ` [PATCH 0/1] " Ilya Leoshkevich
2022-10-25 21:30     ` [PATCH 1/1] tests/tcg/s390x: Add clst.c Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 4/9] target/s390x: Use Int128 for return from CKSM Richard Henderson
2022-10-24 13:17   ` Philippe Mathieu-Daudé
2022-10-27 10:36   ` Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 5/9] target/s390x: Use Int128 for return from TRE Richard Henderson
2022-10-24 13:17   ` Philippe Mathieu-Daudé
2022-10-27 10:40   ` Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 6/9] target/s390x: Copy wout_x1 to wout_x1_P Richard Henderson
2022-10-27 10:57   ` Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 7/9] tests/tcg/s390x: Add long-double.c Richard Henderson
2022-10-24 13:19   ` Philippe Mathieu-Daudé
2022-10-27 11:04   ` Ilya Leoshkevich
2022-10-21  7:30 ` [PATCH 8/9] target/s390x: Use Int128 for returning float128 Richard Henderson
2022-10-25  9:58   ` Philippe Mathieu-Daudé
2022-10-27 11:18   ` Ilya Leoshkevich [this message]
2022-10-27 11:31     ` Richard Henderson
2022-10-21  7:30 ` [PATCH 9/9] target/s390x: Use Int128 for passing float128 Richard Henderson
2022-10-24 18:01   ` Philippe Mathieu-Daudé
2022-10-24 22:31     ` Richard Henderson
2022-11-02  9:38   ` Ilya Leoshkevich
2022-11-02  9:47     ` Richard Henderson
2022-11-02 10:05       ` Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027111802.t7p2txte5qbdtoyz@heavy \
    --to=iii@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.