Re: [PATCH v5 1/8] iio: adc: mp2629: fix wrong comparison of channel

From: Jonathan Cameron <jic23@kernel.org>
To: Saravanan Sekar <sravanhome@gmail.com>
Cc: sre@kernel.org, lee.jones@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, lars@metafoo.de,
	andy.shevchenko@gmail.com, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 1/8] iio: adc: mp2629: fix wrong comparison of channel
Date: Sat, 29 Oct 2022 13:28:33 +0100	[thread overview]
Message-ID: <20221029132833.03afb95e@jic23-huawei> (raw)
In-Reply-To: <20221029093000.45451-2-sravanhome@gmail.com>

On Sat, 29 Oct 2022 11:29:53 +0200
Saravanan Sekar <sravanhome@gmail.com> wrote:

> Input voltage channel enum is compared against iio address instead
> of the channel.
> 
> Fixes: 7abd9fb64682 ("iio: adc: mp2629: Add support for mp2629 ADC driver")
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,
Jonathan

> ---
>  drivers/iio/adc/mp2629_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
> index 30a31f185d08..f7af9af1665d 100644
> --- a/drivers/iio/adc/mp2629_adc.c
> +++ b/drivers/iio/adc/mp2629_adc.c
> @@ -74,7 +74,7 @@ static int mp2629_read_raw(struct iio_dev *indio_dev,
>  		if (ret)
>  			return ret;
>  
> -		if (chan->address == MP2629_INPUT_VOLT)
> +		if (chan->channel == MP2629_INPUT_VOLT)
>  			rval &= GENMASK(6, 0);
>  		*val = rval;
>  		return IIO_VAL_INT;