All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Sven van Ashbrook <svenva@chromium.org>,
	Rafael J Wysocki <rafael@kernel.org>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	<rrangel@chromium.org>, <platform-driver-x86@vger.kernel.org>,
	Rajat Jain <rajatja@google.com>,
	"David E Box" <david.e.box@intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	Mark Gross <markgross@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [RFC 2/3] platform/x86/amd: pmc: Report duration of time in deepest hw state
Date: Mon, 31 Oct 2022 15:43:18 -0500	[thread overview]
Message-ID: <20221031204320.22464-3-mario.limonciello@amd.com> (raw)
In-Reply-To: <20221031204320.22464-1-mario.limonciello@amd.com>

amd_pmc displays a warning when a suspend didn't get to the deepest
state and a dynamic debugging message with the duration if it did.

Rather than logging to dynamic debugging the duration spent in the
deepest state, report this to the standard kernel reporting infrastructure
that can be accessed from sysfs.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/amd/pmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
index 3703b61fb5c00..0f94c919edd43 100644
--- a/drivers/platform/x86/amd/pmc.c
+++ b/drivers/platform/x86/amd/pmc.c
@@ -373,9 +373,7 @@ static void amd_pmc_validate_deepest(struct amd_pmc_dev *pdev)
 
 	if (!table.s0i3_last_entry_status)
 		dev_warn(pdev->dev, "Last suspend didn't reach deepest state\n");
-	else
-		dev_dbg(pdev->dev, "Last suspend in deepest state for %lluus\n",
-			 table.timein_s0i3_lastcapture);
+	pm_set_hw_deepest_state(table.s0i3_last_entry_status ? table.timein_s0i3_lastcapture : 0);
 }
 #endif
 
-- 
2.34.1


  parent reply	other threads:[~2022-10-31 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 20:43 [RFC 0/3] Introduce infrastructure to report time in deepest state Mario Limonciello
2022-10-31 20:43 ` [RFC 1/3] PM: Add a sysfs file to represent whether hardware reached the " Mario Limonciello
2022-11-01 17:37   ` Sven van Ashbrook
2022-11-01 19:58     ` Limonciello, Mario
2022-11-08 20:27   ` David E. Box
2022-10-31 20:43 ` Mario Limonciello [this message]
2022-10-31 20:43 ` [RFC 3/3] platform/x86/intel/pmc: core: Report duration of time in deepest HW state Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221031204320.22464-3-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=david.e.box@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rajatja@google.com \
    --cc=rrangel@chromium.org \
    --cc=svenva@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.