From: Kees Cook <keescook@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3289 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
Date: Tue, 1 Nov 2022 14:42:17 -0700 [thread overview]
Message-ID: <202211011441.0AB5FB92B6@keescook> (raw)
In-Reply-To: <202211012349.5BDBLCup-lkp@intel.com>
On Tue, Nov 01, 2022 at 11:19:40PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5aaef24b5c6d4246b2cac1be949869fa36577737
> commit: f68f2ff91512c199ec24883001245912afc17873 fortify: Detect struct member overflows in memcpy() at compile-time
> date: 9 months ago
> config: x86_64-randconfig-m001-20221031
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> smatch warnings:
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3289 pvr2_hdw_get_tuner_status() warn: inconsistent indenting
Hi!
I have no idea why this is being reported to me. The fortify changes
have nothing to do with the indenting in pvrusb2-hdw.c. :)
-Kees
>
> vim +3289 drivers/media/usb/pvrusb2/pvrusb2-hdw.c
>
> 432907f750b27a drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2008-08-31 3279
> 432907f750b27a drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2008-08-31 3280
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3281 /* Return information about the tuner */
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3282 int pvr2_hdw_get_tuner_status(struct pvr2_hdw *hdw,struct v4l2_tuner *vtp)
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3283 {
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3284 LOCK_TAKE(hdw->big_lock); do {
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3285 if (hdw->tuner_signal_stale) {
> a51f5000b79100 drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2009-03-06 3286 pvr2_hdw_status_poll(hdw);
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3287 }
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3288 memcpy(vtp,&hdw->tuner_signal_info,sizeof(struct v4l2_tuner));
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 @3289 } while (0); LOCK_GIVE(hdw->big_lock);
> 18103c57b0168e drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2007-01-20 3290 return 0;
> d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2006-06-26 3291 }
> d855497edbfbf9 drivers/media/video/pvrusb2/pvrusb2-hdw.c Mike Isely 2006-06-26 3292
>
> :::::: The code at line 3289 was first introduced by commit
> :::::: 18103c57b0168ebc0401702d483fe131f0aecc7a V4L/DVB (5081): Pvrusb2: VIDIOC_G_TUNER cleanup
>
> :::::: TO: Mike Isely <isely@pobox.com>
> :::::: CC: Mauro Carvalho Chehab <mchehab@infradead.org>
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp
--
Kees Cook
next prev parent reply other threads:[~2022-11-01 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 15:19 drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3289 pvr2_hdw_get_tuner_status() warn: inconsistent indenting kernel test robot
2022-11-01 21:42 ` Kees Cook [this message]
2022-11-04 6:50 ` Chen, Rong A
-- strict thread matches above, loose matches on Subject: below --
2022-06-13 3:12 kernel test robot
2022-05-13 6:02 kernel test robot
2022-05-12 5:26 kernel test robot
2022-05-10 13:12 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211011441.0AB5FB92B6@keescook \
--to=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.