From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DA8C433FE for ; Wed, 2 Nov 2022 16:03:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231217AbiKBQDJ (ORCPT ); Wed, 2 Nov 2022 12:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbiKBQCd (ORCPT ); Wed, 2 Nov 2022 12:02:33 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 332C12BB33 for ; Wed, 2 Nov 2022 09:02:30 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id g12so25206864wrs.10 for ; Wed, 02 Nov 2022 09:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qeEG84ShhdCfRruT4hxrr8t/aoGHb3f77grm4bwgQyI=; b=ZeQ4SvR1Kr39bmTHz2yBwzlEZWB3HZEwElltQBJXUyalpCkzCQdnnzfEWrcCQykddq +JNr/eATM4xxzYeKG6JBjN0kLHw2ggsKR+iaQmSBAQ1Hq3LgcCt968v0XPJ8HTXIVdB0 EFlP826AaDuPPOkwKrUzKO8fZdFagEqfdakwQsF0upLENAYMj1PNRb/xgTNUXLRnQPg6 6pnEngRt9UjbW1eAOiQ2sIlLDCgsjc+GqU6Jk26WHD5k89eWuNo3hi2RNFi7fKS7TULu wNVEFrq37WVDMlBrWXWZIuMaSF4F2CSdcPpzPkpfEeTFnO20hkjk2zs1u4p3eGzawS6N +3bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qeEG84ShhdCfRruT4hxrr8t/aoGHb3f77grm4bwgQyI=; b=08hkxFdqau5z1taIYCD2Y4YD0ae9kdX+TiWrRLnWo9uJGzmrIDB8JHzsnVq3UKImkc hRwXAMxr0BYGCwxMHtQ9IfGA0GE34LRLHsAeInUKvIFldznbQP8DIFK47CASfdr8ZFSV 29NN2pb/LsKpPa22spLRlpGVj1nRQTfDTU/YX5G6slMJ5afrPTBcysf8wODo/Q+PTZ/N 6kSE5JA3t2MoVGsXYNs3YFs7tT16x3TOsaSsN5G3FKY1JIMLLdLg0x8DV+2xUiUWIxaG fjwSOHcFwqIAK/+xZcIC3P+Htp9ZYkY+lHeQDNQ9B1+IfnEiBJGeXxLcdsR3Lue8rTmL gsHA== X-Gm-Message-State: ACrzQf00uo7iOLq6tJjibZYLoaLeiFyV5XCiHvdthqk6VYlMBVGgsw1q IKO8I56ADpxJg7WPnQhVufXJQQ== X-Google-Smtp-Source: AMsMyM5YqyPS7e2YBMBWxdaja9Yuops44I1umYCrNxfgkhWPee7fI4EvTPD9YgSErJtGRlUNJqpQeQ== X-Received: by 2002:a05:6000:11cb:b0:236:b1ad:7ae7 with SMTP id i11-20020a05600011cb00b00236b1ad7ae7mr14544885wrx.608.1667404948718; Wed, 02 Nov 2022 09:02:28 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id cy2-20020a056000400200b0022afedf3c87sm13396984wrb.105.2022.11.02.09.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 09:02:28 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, tariqt@nvidia.com, moshe@nvidia.com, saeedm@nvidia.com, linux-rdma@vger.kernel.org Subject: [patch net-next v4 10/13] net: devlink: add not cleared type warning to port unregister Date: Wed, 2 Nov 2022 17:02:08 +0100 Message-Id: <20221102160211.662752-11-jiri@resnulli.us> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221102160211.662752-1-jiri@resnulli.us> References: <20221102160211.662752-1-jiri@resnulli.us> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Jiri Pirko By the time port unregister is called. There should be no type set. Make sure that the driver cleared it before and warn in case it didn't. This enforces symmetricity with type set and port register. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index 38de3a1dff36..4a0ba86b86ed 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -9977,6 +9977,7 @@ EXPORT_SYMBOL_GPL(devlink_port_register); void devl_port_unregister(struct devlink_port *devlink_port) { lockdep_assert_held(&devlink_port->devlink->lock); + WARN_ON(devlink_port->type != DEVLINK_PORT_TYPE_NOTSET); devlink_port_type_warn_cancel(devlink_port); devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_DEL); -- 2.37.3