[PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static

[PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static

[Colin Ian King]

Don't populate the const array ls1028a_soc_attr on the stack, instead
make it static. Also makes the object code smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/spi/spi-nxp-fspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index d6a65a989ef8..1c1991a26c15 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -924,7 +924,7 @@ static int nxp_fspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
 
 static void erratum_err050568(struct nxp_fspi *f)
 {
-	const struct soc_device_attribute ls1028a_soc_attr[] = {
+	static const struct soc_device_attribute ls1028a_soc_attr[] = {
 		{ .family = "QorIQ LS1028A" },
 		{ /* sentinel */ }
 	};
-- 
2.37.3

Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static

[Han Xu]

On 22/11/02 03:29PM, Colin Ian King wrote:
> Don't populate the const array ls1028a_soc_attr on the stack, instead
> make it static. Also makes the object code smaller.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/spi/spi-nxp-fspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index d6a65a989ef8..1c1991a26c15 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -924,7 +924,7 @@ static int nxp_fspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
>  
>  static void erratum_err050568(struct nxp_fspi *f)
>  {
> -	const struct soc_device_attribute ls1028a_soc_attr[] = {
> +	static const struct soc_device_attribute ls1028a_soc_attr[] = {
>  		{ .family = "QorIQ LS1028A" },
>  		{ /* sentinel */ }
>  	};

Acked-by: Han Xu <han.xu@nxp.com>

> -- 
> 2.37.3
> 

Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static

[Mark Brown]

On Wed, 2 Nov 2022 15:29:04 +0000, Colin Ian King wrote:
> Don't populate the const array ls1028a_soc_attr on the stack, instead
> make it static. Also makes the object code smaller.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: nxp-fspi: make const array ls1028a_soc_attr static
      commit: 6c6c49f2c0993ab3ea4bb71a12c800afd0c59e30

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark