From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BFE4C4332F for ; Thu, 3 Nov 2022 11:27:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqYN4-0005H6-JD; Thu, 03 Nov 2022 07:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqYN2-0005FJ-0w; Thu, 03 Nov 2022 07:26:52 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5] helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqYN0-0005Mo-E0; Thu, 03 Nov 2022 07:26:51 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A3A89mt015078; Thu, 3 Nov 2022 11:26:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=thM8Zy7kBHeD+vK7B6OLoV+O6ZzlQrwUpZr8TOGruTo=; b=Yrc57cHBVIw/eC1s7EDQvCF6UxTMRdKvXbRTkPV3b9z7OabSFXavePU+brqw0F0VosRB Y17KUAX19jMewz3c0tqJw+819B2J/OenDCGwYkpym8aEC8d4jqH3TY+Qwp9mM0Bvc/rR dvRgqwuQJx552UrvvkBEoBHEEqP5ujg1YsukZM9hDzcEWHoQcO/eKqo5JSaEOQ+848u+ DC35RPiN62/D2SUQjMSLDCtXJhu8e3LQ3GiSNB78mrFHdF4Ib2d1WPB5/6LuyksyX9q1 QVtvILBlN0WYCcl60O4n5wjl5oBObxtuRWsHe3VAlxlhbQmbO5zTrQeL+t7+0iNfzddo iA== Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3kmbmh25cy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 11:26:48 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2A3BLFn0013258; Thu, 3 Nov 2022 11:26:46 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma05fra.de.ibm.com with ESMTP id 3kjepec8kj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 11:26:46 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2A3BRL7J30343662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Nov 2022 11:27:21 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 674A852050; Thu, 3 Nov 2022 11:26:44 +0000 (GMT) Received: from heavy (unknown [9.171.39.72]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 2A22852057; Thu, 3 Nov 2022 11:26:44 +0000 (GMT) Date: Thu, 3 Nov 2022 12:26:42 +0100 From: Ilya Leoshkevich To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org Subject: Re: [PATCH 08/26] target/s390x: Use gen_psw_addr_disp in pc_to_link_info Message-ID: <20221103112642.cvzz62zvph5xcol2@heavy> References: <20221006034421.1179141-1-richard.henderson@linaro.org> <20221006034421.1179141-9-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006034421.1179141-9-richard.henderson@linaro.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8TbJVjo4yj3ChX5ephVgvWFQly1Wvz2C X-Proofpoint-GUID: 8TbJVjo4yj3ChX5ephVgvWFQly1Wvz2C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-03_02,2022-11-03_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=742 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211030076 Received-SPF: pass client-ip=148.163.158.5; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 05, 2022 at 08:44:03PM -0700, Richard Henderson wrote: > This is slightly more complicated that a straight displacement > for 31 and 24-bit modes. Dont bother with a cant-happen assert. > > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate.c | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) Reviewed-by: Ilya Leoshkevich