All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cosmin Tanislav <demonsingur@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Cosmin Tanislav" <cosmin.tanislav@analog.com>
Subject: [PATCH v4 07/13] dt-bindings: iio: temperature: ltc2983: require 4 wire rtd for current rotate
Date: Thu,  3 Nov 2022 15:00:35 +0200	[thread overview]
Message-ID: <20221103130041.2153295-8-demonsingur@gmail.com> (raw)
In-Reply-To: <20221103130041.2153295-1-demonsingur@gmail.com>

From: Cosmin Tanislav <cosmin.tanislav@analog.com>

The driver will error out when current rotation is enabled but the RTD
is not 4-wire. Require it in the binding too.

Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
 .../bindings/iio/temperature/adi,ltc2983.yaml | 25 +++++++++++--------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index bbac5f5cfbb3..b603219fb0c9 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -230,13 +230,6 @@ patternProperties:
           resistor is used for multiple 2-, 3-, and/or 4-wire RTDs.
         type: boolean
 
-      adi,current-rotate:
-        description:
-          Boolean property which enables excitation current rotation to
-          automatically remove parasitic thermocouple effects. Note that
-          this property is not allowed for 2- and 3-wire RTDs.
-        type: boolean
-
       adi,excitation-current-microamp:
         description:
           This property controls the magnitude of the excitation current
@@ -269,10 +262,22 @@ patternProperties:
     required:
       - adi,rsense-handle
 
-    dependencies:
-      adi,current-rotate: [ "adi,rsense-share" ]
-
     allOf:
+      - if:
+          properties:
+            adi,number-of-wires:
+              const: 4
+        then:
+          properties:
+            adi,current-rotate:
+              description:
+                Whether to enable excitation current rotation to automatically
+                remove parasitic thermocouple effects.
+              type: boolean
+
+          dependencies:
+            adi,current-rotate: [ "adi,rsense-share" ]
+
       - if:
           properties:
             adi,sensor-type:
-- 
2.38.1


  parent reply	other threads:[~2022-11-03 13:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 13:00 [PATCH v4 00/13] Support more parts in LTC2983 Cosmin Tanislav
2022-11-03 13:00 ` [PATCH v4 01/13] iio: temperature: ltc2983: make bulk write buffer DMA-safe Cosmin Tanislav
2022-11-03 13:00 ` [PATCH v4 02/13] dt-bindings: iio: temperature: ltc2983: add default values Cosmin Tanislav
2022-11-07 16:45   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 03/13] dt-bindings: iio: temperature: ltc2983: use hex for sensor address Cosmin Tanislav
2022-11-07 16:49   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 04/13] dt-bindings: iio: temperature: ltc2983: remove qutations from phandle ref Cosmin Tanislav
2022-11-07 16:49   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 05/13] dt-bindings: iio: temperature: ltc2983: describe matrix items Cosmin Tanislav
2022-11-07 16:52   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 06/13] dt-bindings: iio: temperature: ltc2983: require custom sensor tables Cosmin Tanislav
2022-11-07 16:54   ` Rob Herring
2022-11-03 13:00 ` Cosmin Tanislav [this message]
2022-11-07 16:55   ` [PATCH v4 07/13] dt-bindings: iio: temperature: ltc2983: require 4 wire rtd for current rotate Rob Herring
2022-11-03 13:00 ` [PATCH v4 08/13] dt-bindings: iio: temperature: ltc2983: change default excitation for custom thermistors Cosmin Tanislav
2022-11-07 18:08   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 09/13] dt-bindings: iio: temperature: ltc2983: refine descriptions Cosmin Tanislav
2022-11-07 18:10   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 10/13] dt-bindings: iio: temperature: ltc2983: describe broken mux delay property Cosmin Tanislav
2022-11-07 18:11   ` Rob Herring
2022-11-03 13:00 ` [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example Cosmin Tanislav
2022-11-07 18:13   ` Rob Herring
2022-11-08  8:37     ` Cosmin Tanislav
2022-11-12 15:43       ` Jonathan Cameron
2022-11-03 13:00 ` [PATCH v4 12/13] dt-bindings: iio: temperature: ltc2983: support more parts Cosmin Tanislav
2022-11-03 13:00 ` [PATCH v4 13/13] " Cosmin Tanislav
2022-11-06 17:14 ` [PATCH v4 00/13] Support more parts in LTC2983 Jonathan Cameron
2022-11-12 15:44   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103130041.2153295-8-demonsingur@gmail.com \
    --to=demonsingur@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=cosmin.tanislav@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.