From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>,
syzbot+d168ec0caca4697e03b1@syzkaller.appspotmail.com
Subject: Re: [PATCH] can: j1939: fix missing CAN header initialization
Date: Fri, 4 Nov 2022 13:04:30 +0100 [thread overview]
Message-ID: <20221104120430.2e6gbglqvv2hex4v@pengutronix.de> (raw)
In-Reply-To: <20221104075000.105414-1-socketcan@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On 04.11.2022 08:50:00, Oliver Hartkopp wrote:
> The read access to struct canxl_frame::len inside of a j1939 created skbuff
> revealed a missing initialization of reserved and later filled elements in
> struct can_frame.
>
> This patch initializes the 8 byte CAN header with zero.
>
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> Link: https://lore.kernel.org/linux-can/20221104052235.GA6474@pengutronix.de/T/#t
> Reported-by: syzbot+d168ec0caca4697e03b1@syzkaller.appspotmail.com
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied to linux-can + add stable on Cc.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-11-04 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:50 [PATCH] can: j1939: fix missing CAN header initialization Oliver Hartkopp
2022-11-04 12:04 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104120430.2e6gbglqvv2hex4v@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=syzbot+d168ec0caca4697e03b1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.