From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD3C6C4332F for ; Mon, 7 Nov 2022 17:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbiKGRvR (ORCPT ); Mon, 7 Nov 2022 12:51:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231500AbiKGRvO (ORCPT ); Mon, 7 Nov 2022 12:51:14 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE101DA57 for ; Mon, 7 Nov 2022 09:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1667843471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=hdEUekyaNWhEw4kzFyt4Bl/1PuD932ymmDA1Ih0y8+0=; b=HRoelFvULKP+voKUXck7nbcDssqVqd7XyLiJ6fco6NItU5sy8amGPX6kLKHi8CmWPFDwj4 0/v/WE24jJvPE627E5NYGU3YZ7AgkUnR6AwlOS7+G9Vm8+aSWo4BsdYEmf8O7LuQgFE8Le 8n0sYARonZ32Joz5HqfV1fUIdjvy92I= From: Paul Cercueil To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil Subject: [PATCH 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Date: Mon, 7 Nov 2022 17:50:40 +0000 Message-Id: <20221107175106.360578-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This patchset updates the DRM drivers to use the new set of PM-related macros introduced recently. The point of these macros is to allow the PM functions to be automatically dropped by the compiler when CONFIG_PM or CONFIG_SUSPEND is disabled, without having to use #ifdef guards. This has the advantages of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. Note that some drivers (etnaviv, tegra, vc4) currently don't have any .suspend/.resume callbacks, but do provide .runtime_suspend/.runtime_resume callbacks. These drivers should most likely use DEFINE_RUNTIME_DEV_PM_OPS(), which provides .suspend/.resume callbacks as well (pm_runtime_force_suspend / pm_runtime_force_resume respectively). I did not do that, because that would be a functional change and the callbacks being missing may actually be on purpose. Checkpatch complains about patch [11/26], as I replaced a "#if defined(IS_NOT_BROKEN)" to a "if (IS_ENABLED(IS_NOT_BROKEN))". I don't really know how to make it better so I left it like that. Compile-tested with allyesconfig, with the following cases: - CONFIG_PM=y CONFIG_PM_SLEEP=y - CONFIG_PM=y CONFIG_PM_SLEEP=n - CONFIG_PM=n Cheers, -Paul Paul Cercueil (26): drm: modeset-helper: Export dev_pm_ops for simple drivers drm: bochs: Use the dev_pm_ops provided by modeset helper drm: imx: Use the dev_pm_ops provided by modeset helper drm: rockchip: Use the dev_pm_ops provided by modeset helper drm: tegra: Use the dev_pm_ops provided by modeset helper drm: sun4i: Use the dev_pm_ops provided by modeset helper drm: msxfb: Use the dev_pm_ops provided by modeset helper drm: atmel-hlcdc: Remove #ifdef guards for PM related functions drm: exynos: Remove #ifdef guards for PM related functions drm: imx/dcss: Remove #ifdef guards for PM related functions drm: bridge/dw-hdmi: Remove #ifdef guards for PM related functions drm: etnaviv: Remove #ifdef guards for PM related functions drm: fsl-dcu: Remove #ifdef guards for PM related functions drm: mediatek: Remove #ifdef guards for PM related functions drm: omap: Remove #ifdef guards for PM related functions drm: panfrost: Remove #ifdef guards for PM related functions drm: rcar-du: Remove #ifdef guards for PM related functions drm: rockchip: Remove #ifdef guards for PM related functions drm: shmobile: Remove #ifdef guards for PM related functions drm: tegra: Remove #ifdef guards for PM related functions drm: tilcdc: Remove #ifdef guards for PM related functions drm: vboxvideo: Remove #ifdef guards for PM related functions drm: vc4: Remove #ifdef guards for PM related functions drm: gm12u320: Remove #ifdef guards for PM related functions drm: tidss: Remove #ifdef guards for PM related functions drm/i915/gt: Remove #ifdef guards for PM related functions drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 9 +++--- .../drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 17 ++++------ drivers/gpu/drm/drm_modeset_helper.c | 32 +++++++++++++++++++ drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 30 +++++++---------- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 13 +++----- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 12 ++----- drivers/gpu/drm/exynos/exynos_dp.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++---- drivers/gpu/drm/exynos/exynos_drm_mic.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 12 ++----- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 12 ++----- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 9 ++---- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 8 +---- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +++++----- drivers/gpu/drm/imx/dcss/dcss-dev.h | 7 ++-- drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 +---- drivers/gpu/drm/imx/imx-drm-core.c | 21 ++---------- drivers/gpu/drm/mediatek/mtk_dp.c | 6 ++-- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 22 +------------ drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 ++-- drivers/gpu/drm/omapdrm/omap_drv.c | 7 ++-- drivers/gpu/drm/omapdrm/omap_gem.c | 5 +-- drivers/gpu/drm/omapdrm/omap_gem.h | 2 -- drivers/gpu/drm/panfrost/panfrost_device.c | 10 +++--- drivers/gpu/drm/panfrost/panfrost_device.h | 4 +-- drivers/gpu/drm/panfrost/panfrost_drv.c | 7 +--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 ++---- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 6 +--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 23 +------------ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 9 ++---- drivers/gpu/drm/sun4i/sun4i_drv.c | 24 ++------------ drivers/gpu/drm/tegra/dpaux.c | 6 ++-- drivers/gpu/drm/tegra/drm.c | 21 +----------- drivers/gpu/drm/tidss/tidss_drv.c | 29 ++++++++--------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 ++---- drivers/gpu/drm/tiny/bochs.c | 27 ++-------------- drivers/gpu/drm/tiny/gm12u320.c | 15 ++++----- drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 +--- drivers/gpu/drm/vc4/vc4_v3d.c | 6 ++-- include/drm/drm_modeset_helper.h | 4 +++ 43 files changed, 171 insertions(+), 362 deletions(-) -- 2.35.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB9B3C433FE for ; Mon, 7 Nov 2022 17:51:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8269610E865; Mon, 7 Nov 2022 17:51:19 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE93010E865 for ; Mon, 7 Nov 2022 17:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1667843471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=hdEUekyaNWhEw4kzFyt4Bl/1PuD932ymmDA1Ih0y8+0=; b=HRoelFvULKP+voKUXck7nbcDssqVqd7XyLiJ6fco6NItU5sy8amGPX6kLKHi8CmWPFDwj4 0/v/WE24jJvPE627E5NYGU3YZ7AgkUnR6AwlOS7+G9Vm8+aSWo4BsdYEmf8O7LuQgFE8Le 8n0sYARonZ32Joz5HqfV1fUIdjvy92I= From: Paul Cercueil To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: [PATCH 00/26] drm: Get rid of #ifdef CONFIG_PM* guards Date: Mon, 7 Nov 2022 17:50:40 +0000 Message-Id: <20221107175106.360578-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Cercueil , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, This patchset updates the DRM drivers to use the new set of PM-related macros introduced recently. The point of these macros is to allow the PM functions to be automatically dropped by the compiler when CONFIG_PM or CONFIG_SUSPEND is disabled, without having to use #ifdef guards. This has the advantages of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. Note that some drivers (etnaviv, tegra, vc4) currently don't have any .suspend/.resume callbacks, but do provide .runtime_suspend/.runtime_resume callbacks. These drivers should most likely use DEFINE_RUNTIME_DEV_PM_OPS(), which provides .suspend/.resume callbacks as well (pm_runtime_force_suspend / pm_runtime_force_resume respectively). I did not do that, because that would be a functional change and the callbacks being missing may actually be on purpose. Checkpatch complains about patch [11/26], as I replaced a "#if defined(IS_NOT_BROKEN)" to a "if (IS_ENABLED(IS_NOT_BROKEN))". I don't really know how to make it better so I left it like that. Compile-tested with allyesconfig, with the following cases: - CONFIG_PM=y CONFIG_PM_SLEEP=y - CONFIG_PM=y CONFIG_PM_SLEEP=n - CONFIG_PM=n Cheers, -Paul Paul Cercueil (26): drm: modeset-helper: Export dev_pm_ops for simple drivers drm: bochs: Use the dev_pm_ops provided by modeset helper drm: imx: Use the dev_pm_ops provided by modeset helper drm: rockchip: Use the dev_pm_ops provided by modeset helper drm: tegra: Use the dev_pm_ops provided by modeset helper drm: sun4i: Use the dev_pm_ops provided by modeset helper drm: msxfb: Use the dev_pm_ops provided by modeset helper drm: atmel-hlcdc: Remove #ifdef guards for PM related functions drm: exynos: Remove #ifdef guards for PM related functions drm: imx/dcss: Remove #ifdef guards for PM related functions drm: bridge/dw-hdmi: Remove #ifdef guards for PM related functions drm: etnaviv: Remove #ifdef guards for PM related functions drm: fsl-dcu: Remove #ifdef guards for PM related functions drm: mediatek: Remove #ifdef guards for PM related functions drm: omap: Remove #ifdef guards for PM related functions drm: panfrost: Remove #ifdef guards for PM related functions drm: rcar-du: Remove #ifdef guards for PM related functions drm: rockchip: Remove #ifdef guards for PM related functions drm: shmobile: Remove #ifdef guards for PM related functions drm: tegra: Remove #ifdef guards for PM related functions drm: tilcdc: Remove #ifdef guards for PM related functions drm: vboxvideo: Remove #ifdef guards for PM related functions drm: vc4: Remove #ifdef guards for PM related functions drm: gm12u320: Remove #ifdef guards for PM related functions drm: tidss: Remove #ifdef guards for PM related functions drm/i915/gt: Remove #ifdef guards for PM related functions drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 9 +++--- .../drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 17 ++++------ drivers/gpu/drm/drm_modeset_helper.c | 32 +++++++++++++++++++ drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 30 +++++++---------- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 13 +++----- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 12 ++----- drivers/gpu/drm/exynos/exynos_dp.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++---- drivers/gpu/drm/exynos/exynos_drm_mic.c | 11 ++----- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 12 ++----- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 12 ++----- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 9 ++---- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 8 +---- drivers/gpu/drm/imx/dcss/dcss-dev.c | 17 +++++----- drivers/gpu/drm/imx/dcss/dcss-dev.h | 7 ++-- drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 +---- drivers/gpu/drm/imx/imx-drm-core.c | 21 ++---------- drivers/gpu/drm/mediatek/mtk_dp.c | 6 ++-- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 22 +------------ drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 ++-- drivers/gpu/drm/omapdrm/omap_drv.c | 7 ++-- drivers/gpu/drm/omapdrm/omap_gem.c | 5 +-- drivers/gpu/drm/omapdrm/omap_gem.h | 2 -- drivers/gpu/drm/panfrost/panfrost_device.c | 10 +++--- drivers/gpu/drm/panfrost/panfrost_device.h | 4 +-- drivers/gpu/drm/panfrost/panfrost_drv.c | 7 +--- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 ++---- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 6 +--- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 23 +------------ drivers/gpu/drm/shmobile/shmob_drm_drv.c | 9 ++---- drivers/gpu/drm/sun4i/sun4i_drv.c | 24 ++------------ drivers/gpu/drm/tegra/dpaux.c | 6 ++-- drivers/gpu/drm/tegra/drm.c | 21 +----------- drivers/gpu/drm/tidss/tidss_drv.c | 29 ++++++++--------- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 ++---- drivers/gpu/drm/tiny/bochs.c | 27 ++-------------- drivers/gpu/drm/tiny/gm12u320.c | 15 ++++----- drivers/gpu/drm/vboxvideo/vbox_drv.c | 6 +--- drivers/gpu/drm/vc4/vc4_v3d.c | 6 ++-- include/drm/drm_modeset_helper.h | 4 +++ 43 files changed, 171 insertions(+), 362 deletions(-) -- 2.35.1