From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F1C6C4332F for ; Tue, 8 Nov 2022 11:01:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 78AB881C06; Tue, 8 Nov 2022 12:01:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C03CF808A1; Tue, 8 Nov 2022 12:01:27 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id BD21D808A1 for ; Tue, 8 Nov 2022 12:01:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=abdellatif.elkhlifi@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 15BFB1FB; Tue, 8 Nov 2022 03:01:30 -0800 (PST) Received: from e121910.cambridge.arm.com (unknown [10.57.36.86]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1DB8F3F534; Tue, 8 Nov 2022 03:01:22 -0800 (PST) Date: Tue, 8 Nov 2022 11:01:20 +0000 From: Abdellatif El Khlifi To: Ilias Apalodimas Cc: u-boot@lists.denx.de, nd@arm.com Subject: Re: [PATCH v6 10/10] arm_ffa: efi: corstone1000: enable MM communication Message-ID: <20221108110120.GA6268@e121910.cambridge.arm.com> References: <20220926140827.15125-1-abdellatif.elkhlifi@arm.com> <20221013103857.614-1-abdellatif.elkhlifi@arm.com> <20221013103857.614-11-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Oct 24, 2022 at 03:13:08PM +0300, Ilias Apalodimas wrote: > On Thu, Oct 13, 2022 at 11:38:57AM +0100, Abdellatif El Khlifi wrote: > > turn on EFI MM communication > > > > On corstone1000 platform MM communication between u-boot > > and the secure world (Optee) is done using the FF-A bus. > > > > Signed-off-by: Abdellatif El Khlifi > > Cc: Tom Rini > > Cc: Simon Glass > > Cc: Ilias Apalodimas > > Cc: Jens Wiklander > > > > --- > > > > Changelog: > > =============== > > > > v6: > > > > * corstone-1000: enable optee driver > > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defconfig > > > > v4: > > > > * corstone-1000: turn on EFI MM communication > > > > configs/corstone1000_defconfig | 4 ++++ > > include/configs/corstone1000.h | 9 +++++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig > > index ed2e0fe70a..4c9ed9fb71 100644 > > --- a/configs/corstone1000_defconfig > > +++ b/configs/corstone1000_defconfig > > @@ -52,3 +52,7 @@ CONFIG_DM_SERIAL=y > > CONFIG_USB=y > > CONFIG_USB_ISP1760=y > > CONFIG_ERRNO_STR=y > > +CONFIG_EFI_MM_COMM_TEE=y > > +CONFIG_TEE=y > > +CONFIG_OPTEE=y > > +CONFIG_ARM_FFA_TRANSPORT=y > > diff --git a/include/configs/corstone1000.h b/include/configs/corstone1000.h > > index 8e0230c135..997d0bebaf 100644 > > --- a/include/configs/corstone1000.h > > +++ b/include/configs/corstone1000.h > > @@ -14,6 +14,15 @@ > > > > #include > > > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > > + > > +/* > > + * shared buffer physical address used for communication between > > + * u-boot and the MM SP > > + */ > > +#define FFA_SHARED_MM_BUFFER_ADDR (0x023F8000) > > +#define FFA_SHARED_MM_BUFFER_OFFSET (0) > > The rest of the declarations on this file don't have () so please remove > them. Also is FFA_SHARED_MM_BUFFER_ADDR used anywhere that would justify UL > in the suffix? Done in v7. > > Thanks > /Ilias > > + > > #define V2M_BASE 0x80000000 > > > > #define CONFIG_PL011_CLOCK 50000000 > > -- > > 2.17.1 > >