From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85199C4332F for ; Wed, 9 Nov 2022 07:02:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osf5t-0005So-LG; Wed, 09 Nov 2022 02:01:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osf5p-0005Qc-Qu for qemu-devel@nongnu.org; Wed, 09 Nov 2022 02:01:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osf5o-0001LL-4A for qemu-devel@nongnu.org; Wed, 09 Nov 2022 02:01:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667977306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0yDq5uFF1bDHOlQRZKLWD58Arru3aGy3LT0VFgOBqsM=; b=PnLsUMTGuqesH66x3pO3JAX5ntw0l9gyh/HydOgZBBjtuRAimAtnFrTzwL9b7Wndpw2ExU kuUisCRANac7MpEIUrjRmeSykzA6PG/azz2jH/oQOmqH2ddLFFUu6dQTh41P4v6zr0Dl86 I9wTIMjT8Ji8cU9YN5N/TDsgJ+AUHj0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-468-Av26VTDpP8KvBlBQ0AWgtg-1; Wed, 09 Nov 2022 02:01:44 -0500 X-MC-Unique: Av26VTDpP8KvBlBQ0AWgtg-1 Received: by mail-qv1-f72.google.com with SMTP id ob9-20020a0562142f8900b004bba5363ad9so11104685qvb.8 for ; Tue, 08 Nov 2022 23:01:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0yDq5uFF1bDHOlQRZKLWD58Arru3aGy3LT0VFgOBqsM=; b=6Jxob2AGQx9KCt46cM1r9jO3THzwEKpFZ8t8XyrG+bTBK0nto2WtNEJ3qFwuca6wqO sYSizTMC/wdIowmI6yqVnMCvyHubP3awY1U42zH4dH1/FiLSRInQm6I62SzcG2WPuSaZ l57prVCFUirtuMs1+R54lRY741rO9r1fkIlmT/SfZFOPQMUEp0JVcR3+d1MkVv1NElWy YxtRy9ZHPsNwL2FUrpLA7bxAfeNyIFcvRyi6IL+S5z0GS+ZsA7MxLulzgKyV+pyBmh7w mwvbX2aixFjWvZZLwpeWGSgYpJwIVllt6vvzZk6bqQG7kCiEnfBwGYKP0BE7Qxx4RZ0y wf1Q== X-Gm-Message-State: ACrzQf2+y+hTDFNMmf4nkgu5x9Ig62KOI0kS3iqoxe5MIvikTHSSzDzZ MOtQOQsXd9dSYShYNQl7le+giR0uhphBZQ3hzAfZX+Zp0C3RBOdifprcqR8pzOZ1BwL+L4uW5Uh XF/E6vHPSgwEgyo0= X-Received: by 2002:a05:620a:30a:b0:6e7:ea38:cead with SMTP id s10-20020a05620a030a00b006e7ea38ceadmr43230521qkm.702.1667977304380; Tue, 08 Nov 2022 23:01:44 -0800 (PST) X-Google-Smtp-Source: AMsMyM6b7L2kSGlwTJuTvmzKoJyvWVIh7UWgw2iPeRjQs+zxt4r0b3T+hTkN+/1SvtvQjfuWAJHMkw== X-Received: by 2002:a05:620a:30a:b0:6e7:ea38:cead with SMTP id s10-20020a05620a030a00b006e7ea38ceadmr43230509qkm.702.1667977304143; Tue, 08 Nov 2022 23:01:44 -0800 (PST) Received: from redhat.com ([185.195.59.52]) by smtp.gmail.com with ESMTPSA id bj17-20020a05620a191100b006ef1a8f1b81sm10701255qkb.5.2022.11.08.23.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 23:01:43 -0800 (PST) Date: Wed, 9 Nov 2022 02:01:38 -0500 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: Stefan Hajnoczi , Kangjie Xu , qemu-devel@nongnu.org, Peter Maydell , Jason Wang Subject: Re: [PULL v4 29/83] virtio: introduce virtio_queue_enable() Message-ID: <20221109020000-mutt-send-email-mst@kernel.org> References: <20221107224600.934080-30-mst@redhat.com> <20221109013400-mutt-send-email-mst@kernel.org> <1667976509.6798587-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1667976509.6798587-1-xuanzhuo@linux.alibaba.com> Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Nov 09, 2022 at 02:48:29PM +0800, Xuan Zhuo wrote: > On Wed, 9 Nov 2022 01:39:32 -0500, "Michael S. Tsirkin" wrote: > > On Wed, Nov 09, 2022 at 11:31:23AM +0800, Jason Wang wrote: > > > On Wed, Nov 9, 2022 at 3:43 AM Stefan Hajnoczi wrote: > > > > > > > > On Mon, 7 Nov 2022 at 18:10, Michael S. Tsirkin wrote: > > > > > > > > > > From: Kangjie Xu > > > > > > > > > > Introduce the interface queue_enable() in VirtioDeviceClass and the > > > > > fucntion virtio_queue_enable() in virtio, it can be called when > > > > > VIRTIO_PCI_COMMON_Q_ENABLE is written and related virtqueue can be > > > > > started. It only supports the devices of virtio 1 or later. The > > > > > not-supported devices can only start the virtqueue when DRIVER_OK. > > > > > > > > > > Signed-off-by: Kangjie Xu > > > > > Signed-off-by: Xuan Zhuo > > > > > Acked-by: Jason Wang > > > > > Message-Id: <20221017092558.111082-4-xuanzhuo@linux.alibaba.com> > > > > > Reviewed-by: Michael S. Tsirkin > > > > > Signed-off-by: Michael S. Tsirkin > > > > > --- > > > > > include/hw/virtio/virtio.h | 2 ++ > > > > > hw/virtio/virtio.c | 14 ++++++++++++++ > > > > > 2 files changed, 16 insertions(+) > > > > > > > > > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > > > > > index 74d76c1dbc..b00b3fcf31 100644 > > > > > --- a/include/hw/virtio/virtio.h > > > > > +++ b/include/hw/virtio/virtio.h > > > > > @@ -149,6 +149,7 @@ struct VirtioDeviceClass { > > > > > void (*reset)(VirtIODevice *vdev); > > > > > void (*set_status)(VirtIODevice *vdev, uint8_t val); > > > > > void (*queue_reset)(VirtIODevice *vdev, uint32_t queue_index); > > > > > + void (*queue_enable)(VirtIODevice *vdev, uint32_t queue_index); > > > > > /* For transitional devices, this is a bitmap of features > > > > > * that are only exposed on the legacy interface but not > > > > > * the modern one. > > > > > @@ -288,6 +289,7 @@ int virtio_queue_set_host_notifier_mr(VirtIODevice *vdev, int n, > > > > > int virtio_set_status(VirtIODevice *vdev, uint8_t val); > > > > > void virtio_reset(void *opaque); > > > > > void virtio_queue_reset(VirtIODevice *vdev, uint32_t queue_index); > > > > > +void virtio_queue_enable(VirtIODevice *vdev, uint32_t queue_index); > > > > > void virtio_update_irq(VirtIODevice *vdev); > > > > > int virtio_set_features(VirtIODevice *vdev, uint64_t val); > > > > > > > > > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > > > > > index cf5f9ca387..9683b2e158 100644 > > > > > --- a/hw/virtio/virtio.c > > > > > +++ b/hw/virtio/virtio.c > > > > > @@ -2495,6 +2495,20 @@ void virtio_queue_reset(VirtIODevice *vdev, uint32_t queue_index) > > > > > __virtio_queue_reset(vdev, queue_index); > > > > > } > > > > > > > > > > +void virtio_queue_enable(VirtIODevice *vdev, uint32_t queue_index) > > > > > +{ > > > > > + VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev); > > > > > + > > > > > + if (!virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { > > > > > + error_report("queue_enable is only suppported in devices of virtio " > > > > > + "1.0 or later."); > > > > > > > > Why is this triggering here? Maybe virtio_queue_enable() is called too > > > > early. I have verified that the Linux guest driver sets VERSION_1. I > > > > didn't check what SeaBIOS does. > > > > > > Looks like a bug, we should check device features here at least and it > > > should be guest errors instead of error_report() here. > > > > > > Thanks > > > > > > > I suspect we should just drop this print. Kangjie? > > > I think it is. > > At that time, this inspection was only added at hand, and theoretically it > should not be performed. > > I am responsible for this patch set now. > > hi, Michael, > > What should I do, do I send a new version again? > > Thanks. I debugged it and replied separately. Can you check EFI drivers too? > > > > > > > > $ build/qemu-system-x86_64 -M accel=kvm -m 1G -cpu host -blockdev > > > > file,node-name=drive0,filename=test.img -device > > > > virtio-blk-pci,drive=drive0 > > > > qemu: queue_enable is only suppported in devices of virtio 1.0 or later. > > > > > > > > Stefan > > > > > >