From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A44BC433FE for ; Wed, 9 Nov 2022 06:55:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbiKIGzQ (ORCPT ); Wed, 9 Nov 2022 01:55:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiKIGzP (ORCPT ); Wed, 9 Nov 2022 01:55:15 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C09C11C932 for ; Tue, 8 Nov 2022 22:55:14 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 2DA1268AFE; Wed, 9 Nov 2022 07:55:12 +0100 (CET) Date: Wed, 9 Nov 2022 07:55:12 +0100 From: Christoph Hellwig To: Aaron Lu Cc: Mike Rapoport , Song Liu , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, hch@lst.de, rick.p.edgecombe@intel.com, mcgrof@kernel.org Subject: Re: [PATCH bpf-next v2 0/5] execmem_alloc for BPF programs Message-ID: <20221109065512.GA11254@lst.de> References: <20221107223921.3451913-1-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Nov 08, 2022 at 08:38:32PM +0800, Aaron Lu wrote: > set_memory_nx/x() on a vmalloced range will not affect direct map but > set_memory_ro/rw() will. Which seems a little odd. Is there any good reason to not also propagate the NX bit?