From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D3BC4332F for ; Wed, 9 Nov 2022 14:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GqOqpnxbjxX9YzoSnlMs8NswagIunCEHIRQF2lD4lrY=; b=lv6lErGkLrMJzw HexV7JAeOjjD4KtvXW0zMxjmUF9u4L173EuOkeQIeSETRAD5DQx4+Cpm+cBCWbhO8smWWIRD+YMik J5rJVey2iCSCY7OPif27PL/1DepBStYv6ZO9hPF8SJJzW5oX8cgTD7/ChzMOHH7CnE9W9Jc2orJ+J 2LX9OO/npq8QPnp8hwtGnhoaG5unnjgVq+1i6rgyWrab3kKwCRAtBUfGX/ypUd/zst4/KtvZtwH0b 0guV+BKjlLeZc72qYTGur7Ny5kfopc2MMtt827WgLASpsoNqQY/YsdDlmNFL8A2wJj6K//TeSzNJx fuVAU2hZgtYz4xKJpuVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osmSq-00EHHI-2B; Wed, 09 Nov 2022 14:54:04 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osmSn-00EHDo-0E for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 14:54:02 +0000 Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1DBE066029FF; Wed, 9 Nov 2022 14:53:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1668005636; bh=Bwmp25Vc0VJj9gKQf9yBmHI7RP0F72aTQheIjTNTnN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CefQtZ9/iUrkCQOrrekZDe1R9GkHeMjGMzoijn3x30RsdXg6atVhFL1PW/2YpTJJH z9IU2+jg2wpbn0wc0w0ecTF0j+0JZrPAisHRNqO+hCitCKroEhujm9GpICyO9e9FtD Y75jl58UiGsANhY/uQsQ6AngDRIjobi7U0nbRg5/Fatan04Wew7wKJ2bYzDpVs3W1C VBi4M8js1zv3evIIOXqsXANd2+B1kfZmhfbAo96O7ATf8cebK7XFUqRkXObIY1ukJd ENSjKRi07iUHCKczdV6pFNVXUuIRSJ50Ohf6+9LGmsjQNAw8ZT1ELPFQcA0PUkkJHE i8+jgJyMw0/OQ== Date: Wed, 9 Nov 2022 09:53:46 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Krzysztof Kozlowski Cc: Arnd Bergmann , Matthias Brugger , kernel@collabora.com, AngeloGioacchino Del Regno , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Marcel Ziswiler , Mark Brown , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper Message-ID: <20221109145346.prybmdztzc6imdbq@notapiano> References: <20221108232228.1177199-1-nfraprado@collabora.com> <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_065401_277374_9B088250 X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 09, 2022 at 10:08:27AM +0100, Krzysztof Kozlowski wrote: > On 09/11/2022 08:28, Arnd Bergmann wrote: > > On Wed, Nov 9, 2022, at 00:22, N=EDcolas F. R. A. Prado wrote: > >> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests > >> on KernelCI, but several of its drivers are currently disabled in the > >> defconfig. This series enables all the missing kconfigs on the defconf= ig > >> to get everything probing on that machine so that it can be fully test= ed > >> by KernelCI. > > = > > The changes all look fine, but I would recommend not separating it > > out into 13 patches when you are doing just one thing here. = > > = > > As a general rule, if you keep saying the same things in each > > patch description, it is usually an indication that they should > > be combined. Similarly, if you find describing unrelated changes > > ("also, ..."), that would be an indication that patches should > > be split up. > = > I agree. Descriptions you wrote are useful - they explain why you are > doing it - but it got all really too detailed, just for defconfigs. One > commit per one symbol is a bit too much... Okay, thank you both for the feedback. Given that this is a contentious fil= e, splitting independent symbols throughout the commits seemed to be more frie= ndly to possible merge conflicts. But you're right that there's a single overarc= hing goal for all the changes, so I'll join them all into a single commit as suggested. Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B1BC433FE for ; Wed, 9 Nov 2022 14:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbiKIOzx (ORCPT ); Wed, 9 Nov 2022 09:55:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbiKIOz0 (ORCPT ); Wed, 9 Nov 2022 09:55:26 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E51E01EAC6 for ; Wed, 9 Nov 2022 06:53:57 -0800 (PST) Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1DBE066029FF; Wed, 9 Nov 2022 14:53:50 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1668005636; bh=Bwmp25Vc0VJj9gKQf9yBmHI7RP0F72aTQheIjTNTnN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CefQtZ9/iUrkCQOrrekZDe1R9GkHeMjGMzoijn3x30RsdXg6atVhFL1PW/2YpTJJH z9IU2+jg2wpbn0wc0w0ecTF0j+0JZrPAisHRNqO+hCitCKroEhujm9GpICyO9e9FtD Y75jl58UiGsANhY/uQsQ6AngDRIjobi7U0nbRg5/Fatan04Wew7wKJ2bYzDpVs3W1C VBi4M8js1zv3evIIOXqsXANd2+B1kfZmhfbAo96O7ATf8cebK7XFUqRkXObIY1ukJd ENSjKRi07iUHCKczdV6pFNVXUuIRSJ50Ohf6+9LGmsjQNAw8ZT1ELPFQcA0PUkkJHE i8+jgJyMw0/OQ== Date: Wed, 9 Nov 2022 09:53:46 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Krzysztof Kozlowski Cc: Arnd Bergmann , Matthias Brugger , kernel@collabora.com, AngeloGioacchino Del Regno , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Marcel Ziswiler , Mark Brown , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper Message-ID: <20221109145346.prybmdztzc6imdbq@notapiano> References: <20221108232228.1177199-1-nfraprado@collabora.com> <06c4f370-715d-4c66-ad43-143b652af5ff@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 09, 2022 at 10:08:27AM +0100, Krzysztof Kozlowski wrote: > On 09/11/2022 08:28, Arnd Bergmann wrote: > > On Wed, Nov 9, 2022, at 00:22, Nícolas F. R. A. Prado wrote: > >> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests > >> on KernelCI, but several of its drivers are currently disabled in the > >> defconfig. This series enables all the missing kconfigs on the defconfig > >> to get everything probing on that machine so that it can be fully tested > >> by KernelCI. > > > > The changes all look fine, but I would recommend not separating it > > out into 13 patches when you are doing just one thing here. > > > > As a general rule, if you keep saying the same things in each > > patch description, it is usually an indication that they should > > be combined. Similarly, if you find describing unrelated changes > > ("also, ..."), that would be an indication that patches should > > be split up. > > I agree. Descriptions you wrote are useful - they explain why you are > doing it - but it got all really too detailed, just for defconfigs. One > commit per one symbol is a bit too much... Okay, thank you both for the feedback. Given that this is a contentious file, splitting independent symbols throughout the commits seemed to be more friendly to possible merge conflicts. But you're right that there's a single overarching goal for all the changes, so I'll join them all into a single commit as suggested. Thanks, Nícolas