[PATCH] pinctrl: devicetree: fix null pointer dereferencing in pinctrl_dt_to_map

From: Zeng Heng <zengheng4@huawei.com>
To: <linus.walleij@linaro.org>, <dong.aisheng@linaro.org>,
	<swarren@wwwdotorg.org>
Cc: <linux-gpio@vger.kernel.org>, <zengheng4@huawei.com>,
	<liwei391@huawei.com>
Subject: [PATCH] pinctrl: devicetree: fix null pointer dereferencing in pinctrl_dt_to_map
Date: Thu, 10 Nov 2022 16:20:56 +0800	[thread overview]
Message-ID: <20221110082056.2014898-1-zengheng4@huawei.com> (raw)

Here is the BUG report by KASAN about null pointer dereference:

BUG: KASAN: null-ptr-deref in strcmp+0x2e/0x50
Read of size 1 at addr 0000000000000000 by task python3/2640
Call Trace:
 strcmp
 __of_find_property
 of_find_property
 pinctrl_dt_to_map

kasprintf() would return NULL pointer when kmalloc() fail to allocate.
So directly return ENOMEM, if kasprintf() return NULL pointer.

Fixes: 57291ce295c0 ("pinctrl: core device tree mapping table parsing support")
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
---
 drivers/pinctrl/devicetree.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
index ef898ee8ca6b..6e0a40962f38 100644
--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -220,6 +220,8 @@ int pinctrl_dt_to_map(struct pinctrl *p, struct pinctrl_dev *pctldev)
 	for (state = 0; ; state++) {
 		/* Retrieve the pinctrl-* property */
 		propname = kasprintf(GFP_KERNEL, "pinctrl-%d", state);
+		if (!propname)
+			return -ENOMEM;
 		prop = of_find_property(np, propname, &size);
 		kfree(propname);
 		if (!prop) {
-- 
2.25.1

