From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB347C4332F for ; Thu, 10 Nov 2022 11:37:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9536F8514F; Thu, 10 Nov 2022 12:37:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="BY4JllqU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CEEA785152; Thu, 10 Nov 2022 12:37:34 +0100 (CET) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5860885161 for ; Thu, 10 Nov 2022 12:37:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from workstation5.fritz.box (ip-084-118-157-002.um23.pools.vodafone-ip.de [84.118.157.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id AB821431C7; Thu, 10 Nov 2022 11:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668080248; bh=B7BFIRoNv6EZB8NUxSeX3em3R/BDEZ75p+4L1I4mLYs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BY4JllqUk7YY8CwYdFzkSmKOYfmZto2bvMDm7O7VHmVhQf+6WuPvMas6qR+I9K/Bv Uc3QNzxYMDpXMPG0mQYmqFD5Y5O7P3g3NhDa4GEH/AAUFy7mKC5bWOTK0jPxP2fXKl VkrdDxCKnxZsi52nzKwIt7pJNbeS77LS8Y8rHOfU8LV+BtFSZJFbd4SKYSg3EXWSEW BCP1CWAlvCqTMH7lmHv19RAS50dYFL4hfDEqxxJHA8ZQXQJ5xQYQZCnmMi/alcO8Uq /E125BRTfbsf70Zdh/O65PeExLn6vDc8R/4pX5t553Lxxvfoiah7NtEhkYjbsnVMLy 3N5KO2+ahV1Ng== From: Heinrich Schuchardt To: Ilias Apalodimas Cc: Masahisa Kojima , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option Date: Thu, 10 Nov 2022 12:37:27 +0100 Message-Id: <20221110113727.861220-1-heinrich.schuchardt@canonical.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Goto for an immediately succeeding label is superfluous. Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option") Addresses-Coverity: 376202 ("Identical code for different branches") Signed-off-by: Heinrich Schuchardt --- cmd/eficonfig.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 2595dd9563..0dc6e7b01e 100644 --- a/cmd/eficonfig.c +++ b/cmd/eficonfig.c @@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo } ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp); - if (ret != EFI_SUCCESS) - goto out; out: free(tmp); free(bo->optional_data); -- 2.37.2