All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc: stefanb@linux.vnet.ibm.com, linux@mniewoehner.de,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	jandryuk@gmail.com, pmenzel@molgen.mpg.de,
	l.sanfilippo@kunbus.com, LinoSanfilippo@gmx.de, lukas@wunner.de,
	p.rosenberger@kunbus.com
Subject: [PATCH v9 12/12] tpm, tpm_tis: Enable interrupt test
Date: Thu, 10 Nov 2022 16:25:33 +0100	[thread overview]
Message-ID: <20221110152533.24243-13-LinoSanfilippo@gmx.de> (raw)
In-Reply-To: <20221110152533.24243-1-LinoSanfilippo@gmx.de>

From: Lino Sanfilippo <l.sanfilippo@kunbus.com>

The test for interrupts in tpm_tis_send() is skipped if the flag
TPM_CHIP_FLAG_IRQ is not set. Since the current code never sets the flag
initially the test is never executed.

Fix this by setting the flag in tpm_tis_gen_interrupt() right after
interrupts have been enabled and before the test is executed.

Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
---
 drivers/char/tpm/tpm_tis_core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 469a1db95941..1f78582264eb 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -793,6 +793,8 @@ static int tpm_tis_gen_interrupt(struct tpm_chip *chip)
 	if (ret < 0)
 		return ret;
 
+	chip->flags |= TPM_CHIP_FLAG_IRQ;
+
 	if (chip->flags & TPM_CHIP_FLAG_TPM2)
 		ret = tpm2_get_tpm_pt(chip, 0x100, &cap2, desc);
 	else
-- 
2.36.1


  parent reply	other threads:[~2022-11-10 15:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 15:25 [PATCH v9 00/12] TPM IRQ fixes Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 01/12] tpm, tpm_tis: Avoid cache incoherency in test for interrupts Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 02/12] tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 03/12] tpm, tpm_tis: Disable interrupts if tpm_tis_probe_irq() failed Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 04/12] tpm, tmp_tis: Claim locality before writing interrupt registers Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 05/12] tpm, tpm_tis: Only handle supported interrupts Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 06/12] tpm, tpm_tis: Move interrupt mask checks into own function Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 07/12] tpm, tpm_tis: do not check for the active locality in interrupt handler Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 08/12] tpm, tpm: Implement usage counter for locality Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 09/12] tpm, tpm_tis: Request threaded interrupt handler Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 10/12] tpm, tpm_tis: Claim locality in " Lino Sanfilippo
2022-11-10 15:25 ` [PATCH v9 11/12] tpm, tpm_tis: Claim locality when interrupts are reenabled on resume Lino Sanfilippo
2022-11-10 15:25 ` Lino Sanfilippo [this message]
2022-11-14 13:35   ` [PATCH v9 12/12] tpm, tpm_tis: Enable interrupt test Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221110152533.24243-13-LinoSanfilippo@gmx.de \
    --to=linosanfilippo@gmx.de \
    --cc=jandryuk@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mniewoehner.de \
    --cc=lukas@wunner.de \
    --cc=p.rosenberger@kunbus.com \
    --cc=peterhuewe@gmx.de \
    --cc=pmenzel@molgen.mpg.de \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.