From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68E3AC4332F for ; Thu, 10 Nov 2022 16:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbiKJQM3 (ORCPT ); Thu, 10 Nov 2022 11:12:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbiKJQM2 (ORCPT ); Thu, 10 Nov 2022 11:12:28 -0500 X-Greylist: delayed 478 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 10 Nov 2022 08:12:25 PST Received: from mail.enpas.org (zhong.enpas.org [IPv6:2a03:4000:2:537::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 828007642; Thu, 10 Nov 2022 08:12:25 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 9C730FFA84; Thu, 10 Nov 2022 16:04:22 +0000 (UTC) Date: Fri, 11 Nov 2022 01:04:12 +0900 From: Max Staudt To: Ziyang Xuan Cc: , , , , , , , , , Vincent Mailhol Subject: Re: [PATCH] can: can327: fix potential skb leak when netdev is down Message-ID: <20221111010412.6ca0ff1c.max@enpas.org> In-Reply-To: <20221110061437.411525-1-william.xuanziyang@huawei.com> References: <20221110061437.411525-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org (CC Vincent, he may be interested) On Thu, 10 Nov 2022 14:14:37 +0800 Ziyang Xuan wrote: > Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev > is down. Not tested, just compiled. Looks correct to me, so: Reviewed-by: Max Staudt Thank you very much for finding and fixing this! Max