From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E24C4332F for ; Fri, 11 Nov 2022 02:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231753AbiKKCxO (ORCPT ); Thu, 10 Nov 2022 21:53:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233125AbiKKCwz (ORCPT ); Thu, 10 Nov 2022 21:52:55 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91452EE19; Thu, 10 Nov 2022 18:52:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F33961E84; Fri, 11 Nov 2022 02:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1131FC433D6; Fri, 11 Nov 2022 02:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668135165; bh=sZ0z3LPYriwx/rk2VZkne10P2Vh1hJUJ5kAQewV4+eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BW2pHWXbynJWLIfbdKcPOh4SjwGf40tr6tCIyCac7aSm5ys6JhoAPw530RherP5bx /dLO+tdf4YiJT0DJ081GKYSuqNhfL9wit8LptaDVsrD+zGti6LYJCNxTpUtEpjga4w 0psglM0sf1VwsuTeZJbUlMporJAXzoxPIfYn6K5dJ+C4D+xHF6Smiohvu3jxTbPAmQ Gt/Y47ya1kDe84xd1qqYMwUD77N5P1NJNaq9odgeR3emhvrCSRajLRy0ndl0XQA0L4 +Z/iBdJjKulTyCOlEVDa6sDLjaUzEo9pHOSzGAQkqhvWPR+QuuHTWA0YnNj2h1FnA2 Dddx/X8ZBie4g== Date: Fri, 11 Nov 2022 10:52:32 +0800 From: Shawn Guo To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH] ARM: dts: imx6qdl-sabre: Add mmc aliases Message-ID: <20221111025232.GI125525@dragon> References: <20221028141811.101122-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221028141811.101122-1-detlev.casanova@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 28, 2022 at 10:18:11AM -0400, Detlev Casanova wrote: > If not specified, the mmc0 and mmc1 devices will be the devices > mmc@2190000 and mmc@2194000, which are in disabled state on the iMX.6 > Sabrelite devices. > > The actual SD card reader devices are the ones at mmc@2198000 and > mmc@219c000. > > Set aliases to use the correct mmc devices order. Is this something never worked or a regression? For the latter, we may need a Fixes tag? Shawn > > Signed-off-by: Detlev Casanova > --- > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > index 22f8e2783cdf..12573e1f917c 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > @@ -14,6 +14,11 @@ chosen { > stdout-path = &uart2; > }; > > + aliases { > + mmc0 = &usdhc3; > + mmc1 = &usdhc4; > + }; > + > memory@10000000 { > device_type = "memory"; > reg = <0x10000000 0x40000000>; > -- > 2.38.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11483C4332F for ; Fri, 11 Nov 2022 02:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8HZFSA3N0pxbGNI4hPpfuwtrS4XmLV0S5wBF/A1h8PQ=; b=05bGRACW+4Apsm 2CEpuE5fkR4BOoglWAaBuLorufE6vXNK9j7DBQ803pMfrP8bGMiYJ74B1wHHQDBOyLVgTwDlbwlBP 8dWfw/0MpBx7esta4nCH6t75o/TwrzABl0/0jIoH7em4e/KNHGxiQBkDMdssW8fWYuUAWBpZMvtJ+ DB5zeTKsHVL6TjNCq5LjdfoXSTyXKDCxGOgiwMiO+dKSrGhvFAj5FU5iYfjkXBXv6gG/vwJbOIE4b zgAzDs3aL+zuYbbu008PvDbj8xqcIG/r3rpaGc4Cc2h0QY2OCFOuINX57oijINiSBADreUrkzowtX KHT9DfoMc9KqLqpFKi7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otK9y-00CKRY-Gr; Fri, 11 Nov 2022 02:52:50 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otK9v-00CKPA-Bz for linux-arm-kernel@lists.infradead.org; Fri, 11 Nov 2022 02:52:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 241D261E31; Fri, 11 Nov 2022 02:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1131FC433D6; Fri, 11 Nov 2022 02:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668135165; bh=sZ0z3LPYriwx/rk2VZkne10P2Vh1hJUJ5kAQewV4+eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BW2pHWXbynJWLIfbdKcPOh4SjwGf40tr6tCIyCac7aSm5ys6JhoAPw530RherP5bx /dLO+tdf4YiJT0DJ081GKYSuqNhfL9wit8LptaDVsrD+zGti6LYJCNxTpUtEpjga4w 0psglM0sf1VwsuTeZJbUlMporJAXzoxPIfYn6K5dJ+C4D+xHF6Smiohvu3jxTbPAmQ Gt/Y47ya1kDe84xd1qqYMwUD77N5P1NJNaq9odgeR3emhvrCSRajLRy0ndl0XQA0L4 +Z/iBdJjKulTyCOlEVDa6sDLjaUzEo9pHOSzGAQkqhvWPR+QuuHTWA0YnNj2h1FnA2 Dddx/X8ZBie4g== Date: Fri, 11 Nov 2022 10:52:32 +0800 From: Shawn Guo To: Detlev Casanova Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH] ARM: dts: imx6qdl-sabre: Add mmc aliases Message-ID: <20221111025232.GI125525@dragon> References: <20221028141811.101122-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221028141811.101122-1-detlev.casanova@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_185247_479228_4A7B790D X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 28, 2022 at 10:18:11AM -0400, Detlev Casanova wrote: > If not specified, the mmc0 and mmc1 devices will be the devices > mmc@2190000 and mmc@2194000, which are in disabled state on the iMX.6 > Sabrelite devices. > > The actual SD card reader devices are the ones at mmc@2198000 and > mmc@219c000. > > Set aliases to use the correct mmc devices order. Is this something never worked or a regression? For the latter, we may need a Fixes tag? Shawn > > Signed-off-by: Detlev Casanova > --- > arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > index 22f8e2783cdf..12573e1f917c 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabrelite.dtsi > @@ -14,6 +14,11 @@ chosen { > stdout-path = &uart2; > }; > > + aliases { > + mmc0 = &usdhc3; > + mmc1 = &usdhc4; > + }; > + > memory@10000000 { > device_type = "memory"; > reg = <0x10000000 0x40000000>; > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel