Hi Junhao, I love your patch! Perhaps something to improve: [auto build test WARNING on soc/for-next] [also build test WARNING on linus/master v6.1-rc4 next-20221111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Junhao-He/Add-support-for-UltraSoc-System-Memory-Buffer/20221109-215158 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next patch link: https://lore.kernel.org/r/20221109135008.9485-2-hejunhao3%40huawei.com patch subject: [PATCH v12 1/2] drivers/coresight: Add UltraSoc System Memory Buffer driver config: arm64-randconfig-r023-20221111 compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/49ede03fd874b65deca5382ea84c3377188136da git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Junhao-He/Add-support-for-UltraSoc-System-Memory-Buffer/20221109-215158 git checkout 49ede03fd874b65deca5382ea84c3377188136da # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/hwtracing/coresight/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/hwtracing/coresight/ultrasoc-smb.c: In function 'smb_config_inport': >> drivers/hwtracing/coresight/ultrasoc-smb.c:553:31: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] 553 | ACPI_FREE(obj); | ^ drivers/hwtracing/coresight/ultrasoc-smb.c: At top level: drivers/hwtracing/coresight/ultrasoc-smb.c:615:36: warning: 'ultrasoc_smb_acpi_match' defined but not used [-Wunused-const-variable=] 615 | static const struct acpi_device_id ultrasoc_smb_acpi_match[] = { | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/else +553 drivers/hwtracing/coresight/ultrasoc-smb.c 532 533 static int smb_config_inport(struct device *dev, bool enable) 534 { 535 u64 func = enable ? 1 : 0; 536 union acpi_object *obj; 537 guid_t guid; 538 u64 rev = 0; 539 540 /* 541 * Using DSM calls to enable/disable ultrasoc hardwares on 542 * tracing path, to prevent ultrasoc packet format being exposed. 543 */ 544 if (guid_parse(ULTRASOC_SMB_DSM_UUID, &guid)) { 545 dev_err(dev, "Get GUID failed\n"); 546 return -EINVAL; 547 } 548 549 obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &guid, rev, func, NULL); 550 if (!obj) 551 dev_err(dev, "ACPI handle failed\n"); 552 else > 553 ACPI_FREE(obj); 554 555 return 0; 556 } 557 -- 0-DAY CI Kernel Test Service https://01.org/lkp