From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B99C433FE for ; Sat, 12 Nov 2022 14:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbiKLOkH (ORCPT ); Sat, 12 Nov 2022 09:40:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiKLOkG (ORCPT ); Sat, 12 Nov 2022 09:40:06 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A121C40F for ; Sat, 12 Nov 2022 06:40:03 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id k7so6463089pll.6 for ; Sat, 12 Nov 2022 06:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bIZDCVzPPjeVdKIk8F8Uv0L3duOYsMu0/eWhzix57vE=; b=SgtHZqh9wD+qbdxjkCbxLhKl2gLUkSUxEOoQ/Yiftl9N9XRaN42vlI0WUcwXwfVXTn J6E2JYQ8k4+o0ExPP46zeFzPP9gkSID52C1MH3BDWFsznZDOQ22cUReZmwSGEONfC0jr CTZwDa+yLcLl/rugWxr0sFDXiAq1CrC8GZ5m01Am09CHbV6Yu0LL67moMmJdL4jX3wG3 yR9xJ6ITd0obGZcqR+FCEawTV3cFC1OcWkRcu4hQ+KsLl7XO+MjVPvJnrX7k6fuNitoM 9oEiK5THRlXDHQ1pysOPZt5UNwvGmEtyepvH59+xxN5ItKPE0WQEeGCdNOF7NbnZ6G11 s8mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bIZDCVzPPjeVdKIk8F8Uv0L3duOYsMu0/eWhzix57vE=; b=CeT5xobLJOzrsT1m5tgGQoPzgAtLoYmaWbxVafeEQ7FQcUeDJd/LxddRf9z6ziY0Y6 XD6E/FkXxcDAES1hVQ/xxdBX52STHvQnEri4ZWU5l2bUIfZZBVrfD1rW7tkLyUSklnul BAOcYFXHXKQDOizOO+GO0rWOaVQJXWtzxBMLNNxUdnAO4CTEpQzLuvYrZ6M7Cm4ccXok ZyprlqisbptvBIV95X8qbLTb8npCI1UP5b+1XgGAXHwWOnAwRX42cTd/X4Z/iTkWC/zq RvQfSap14z/OdqDK0I3/X5wIDRRLBHTUw+moVd65lFxJwIdaYHXbcxN3MGl7iufML7yz XkxQ== X-Gm-Message-State: ANoB5pkpduC0TM340rDvsKBMgqzHy0GjSyltT1GOJdiI41Fyr6w7KheP 11Hqk1EP0DebFh0U2k8KfuUa X-Google-Smtp-Source: AA0mqf4V0MvKh/F4vjxhQra+NmLToI21qXSfrRqdxC8PQ11CWY9xPpq9a08b0yLlvng1AqaZ7MEfvA== X-Received: by 2002:a17:902:7247:b0:186:6f97:fe90 with SMTP id c7-20020a170902724700b001866f97fe90mr6684390pll.75.1668264003242; Sat, 12 Nov 2022 06:40:03 -0800 (PST) Received: from thinkpad ([2409:4072:6d03:e3e3:883:ee9e:a771:761d]) by smtp.gmail.com with ESMTPSA id d187-20020a6236c4000000b0056bdb5197f4sm3386924pfa.35.2022.11.12.06.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Nov 2022 06:40:02 -0800 (PST) Date: Sat, 12 Nov 2022 20:09:55 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: Johan Hovold , Johan Hovold , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc8280xp-crd: enable WiFi controller Message-ID: <20221112143537.GA140906@thinkpad> References: <20221110103558.12690-1-johan+linaro@kernel.org> <20221110103558.12690-7-johan+linaro@kernel.org> <20221110113513.GA18247@thinkpad> <20221111204021.myjms5c2rntu4a76@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221111204021.myjms5c2rntu4a76@builder.lan> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Nov 11, 2022 at 02:40:21PM -0600, Bjorn Andersson wrote: > On Fri, Nov 11, 2022 at 05:27:46PM +0100, Johan Hovold wrote: > > On Thu, Nov 10, 2022 at 05:05:13PM +0530, Manivannan Sadhasivam wrote: > > > On Thu, Nov 10, 2022 at 11:35:55AM +0100, Johan Hovold wrote: > > > > Enable the Qualcomm QCNFA765 Wireless Network Adapter connected to > > > > PCIe4. > > > > > > > > Signed-off-by: Johan Hovold > > > > --- > > > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 65 +++++++++++++++++++++++ > > > > 1 file changed, 65 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > > > > index 5b9e37a16f9f..ab5b0aadeead 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > > > > @@ -81,6 +81,22 @@ vreg_misc_3p3: regulator-misc-3p3 { > > > > regulator-always-on; > > > > }; > > > > > > > > + vreg_wlan: regulator-wlan { > > > > + compatible = "regulator-fixed"; > > > > + > > > > + regulator-name = "VCC_WLAN_3R9"; > > > > + regulator-min-microvolt = <3900000>; > > > > + regulator-max-microvolt = <3900000>; > > > > + > > > > + gpio = <&pmr735a_gpios 1 GPIO_ACTIVE_HIGH>; > > > > + enable-active-high; > > > > + > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&hastings_reg_en>; > > > > > > Hastings is the family name of QCA639x WLAN chipsets. I don't think it would be > > > applicable here. Please use "wlan_reg_en" as that matches the convention used > > > throughout this file. > > > > The pin name here comes from the schematics, which is what we should use > > for naming when we can. If hastings is what mentioned in the schematics then it is fine (I can see that now). For a moment I thought it came from downstream... Thanks, Mani > > > > Following the naming in the schematics is the right thing to do. > > Regards, > Bjorn -- மணிவண்ணன் சதாசிவம்